From: "Òscar Forner Martínez" <oscar.forner.martinez@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: zajec5@gmail.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] Drivers: bcma: Fix three coding style issues, more than 80 characters per line.
Date: Wed, 24 Dec 2014 09:44:02 +0000 [thread overview]
Message-ID: <4E065003-D723-47FD-B463-C1C0C4C238E2@gmail.com> (raw)
In-Reply-To: <877fxhbjj8.fsf@kamboji.qca.qualcomm.com>
Hi Kalle,
I am doing it from London with the timezone of Spain, maybe is that the odd stuff? I can change it and do the patch again. I will check the style guide to do the changes properly this time. I have a couple of questions, as it is my first patch I am not sure how to do them.
Do I have to sent the V2 of the patch as the previous one? or I have to do something to follow that one?
Regards,
Oscar
On 24 Dec 2014, at 07:20, Kalle Valo <kvalo@codeaurora.org> wrote:
> Oscar Forner Martinez <oscar.forner.martinez@gmail.com> writes:
>
>> Three lines with more than 80 characters per line have been split in several lines.
>>
>> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@gmail.com>
>> ---
>> drivers/bcma/driver_chipcommon.c | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> Just to handle the bureaucracy before v2 is submitted:
>
> To which tree should this go to? I see that earlier John has applied
> patches to drivers/bcma/, but what about now? Should I take these? John,
> any suggestions?
>
> Oscar, the patchwork entry for this patch looked odd. I'm guessing it
> was because your time (or timezone) is wrong:
>
> https://patchwork.kernel.org/patch/5535751/
>
> --
> Kalle Valo
next prev parent reply other threads:[~2014-12-24 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 23:55 Oscar Forner Martinez
2014-12-23 23:46 ` Rafał Miłecki
2014-12-24 0:55 ` Joe Perches
2014-12-23 23:47 ` Rafał Miłecki
2014-12-24 7:20 ` Kalle Valo
2014-12-24 9:09 ` Arend van Spriel
2014-12-24 9:44 ` Òscar Forner Martínez [this message]
2014-12-26 9:19 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E065003-D723-47FD-B463-C1C0C4C238E2@gmail.com \
--to=oscar.forner.martinez@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®