From: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Alexander Stein <alexander.stein@systec-electronic.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"toshiharu-linux@dsn.okisemi.com"
<toshiharu-linux@dsn.okisemi.com>
Subject: Re: [PATCH] pch_gpio: transform mutex into spinlock
Date: Tue, 28 Jun 2011 10:02:12 +0900 [thread overview]
Message-ID: <4E092814.1080701@dsn.okisemi.com> (raw)
In-Reply-To: <20110627224722.GG20865@ponder.secretlab.ca>
(2011/06/28 7:47), Grant Likely wrote:
> On Tue, Jun 21, 2011 at 04:17:27PM +0200, Alexander Stein wrote:
>> gpio_chip.can_sleep is 0, but gpio_set_value& friends lock a mutex. Thus
>> those functions are not callable from interrupt context.
>> Changing mutex into spinlock.
>>
>> Signed-off-by: Alexander Stein<alexander.stein@systec-electronic.com>
>
> Tomoya, what do you think of this patch?
>
Seeing some upstreamed GPIO driver, Alexander's comment looks right.
Best Regards,
tomoya
OKI SEMICONDUCTOR CO., LTD.
prev parent reply other threads:[~2011-06-28 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 14:17 Alexander Stein
2011-06-27 22:47 ` Grant Likely
2011-06-28 1:02 ` Tomoya MORINAGA [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E092814.1080701@dsn.okisemi.com \
--to=tomoya-linux@dsn.okisemi.com \
--cc=alexander.stein@systec-electronic.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=toshiharu-linux@dsn.okisemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome