From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756822Ab1GDJg4 (ORCPT ); Mon, 4 Jul 2011 05:36:56 -0400 Received: from ppsw-52.csi.cam.ac.uk ([131.111.8.152]:35784 "EHLO ppsw-52.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379Ab1GDJgy (ORCPT ); Mon, 4 Jul 2011 05:36:54 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Message-ID: <4E118B9D.2070104@cam.ac.uk> Date: Mon, 04 Jul 2011 10:45:01 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110509 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: Dan Carpenter CC: Chris Forbes , devel@driverdev.osuosl.org, "linux-iio@vger.kernel.org" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: iio: adc: fix uninitialized use References: <1309657621-21711-1-git-send-email-chrisf@ijw.co.nz> <4E118157.3020906@cam.ac.uk> <20110704091016.GM2544@shale.localdomain> In-Reply-To: <20110704091016.GM2544@shale.localdomain> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/04/11 10:10, Dan Carpenter wrote: > On Mon, Jul 04, 2011 at 10:01:11AM +0100, Jonathan Cameron wrote: >> On 07/03/11 02:47, Chris Forbes wrote: >>> Fixed an uninitialized variable access. In the first two error paths in >>> max1363_probe(), 'st' is not yet initialized, but its 'reg' member is >>> accessed anyway. This would most likely crash. >> Good spot. Please tech TODO files for staging patches. In this case it would >> have given you the mailing list, now cc'd. > > It would better to add an entry to MAINTAINERS so that > ./scripts/get_maintainer.pl gave the right lists. Perhaps, but Greg KH is anti, so it isn't going to happen.