From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4DC2277CA4; Thu, 4 Sep 2025 12:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756990584; cv=pass; b=TFjJ/W0uExNt00SGpoUF5xv2bq0FUc/dAXmFnwGcu9rp1A+9ohYBKlX1vtM23sGJSVQi18EI9WW+FA6RMt20Y6BHRdvttJR7FBq0brHJnCugVqIv9BWlZhdwZEfaSONXBRQQhXDBp1Axg4WtNezWscYxwvLSFYwQbW9dtjVGTx8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756990584; c=relaxed/simple; bh=wkdmqXKZo1tHNEjUJXXVj27FZ7Zjg6MMvyBcbROIYJY=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=YbfsO/VAm7IZxZlUYmTKKEDKJgm/QEyd2rVOX2OUbjJAr7fO83ZWHVJB5syPxyAX4l4EHuhE+fA2St1ZM1EtOJaBk2cSv2fm6eKVJchENom+zcF93RYRTcFSJ7d1la/PSKI+S6EsCKw1luJwdwt751hMQchZ3dZFGoBBBjwYdIo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=BII/ePzk; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="BII/ePzk" ARC-Seal: i=1; a=rsa-sha256; t=1756990551; cv=none; d=zohomail.com; s=zohoarc; b=Ol/OxM4mp3DvaV5G8Oz2RkBldtrtCDfPwxGRyWQvSW417obvnAHslBBLEenHdNqeKHRCaqmBHM4xitqVV+aN3+zwDsrhhd1YAcWM1MnnJ6FlIZqQ+/UbhHE7beDm5NWyyR5GyzB0vx9ox0awcgDjvYTi+dZXQRQJlJ5RAg0gMv8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756990551; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=4yQXcYDvDkWrXuTPgSfbG55Fo5/awg+Dvlk2c39nTQc=; b=jE/9ASCAC5cm3vBRjWPE9ycgDNDjX6GGV+XfZ3OrfnQrnZnF2yJddB1Fc9MAc+P4lQZ5lvpmkFb9AK3hPKHNMuv+mja5OYsZAFM7959goLqkOtlCRxHzYNFF0VdtMnT0DEKVVjFxIfHvfrzfILf0Y6bJ/uHfJb+v9wtD+4l1LdA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1756990551; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=Content-Type:Mime-Version:Subject:Subject:From:From:In-Reply-To:Date:Date:Cc:Cc:Content-Transfer-Encoding:Message-Id:Message-Id:References:To:To:Reply-To; bh=4yQXcYDvDkWrXuTPgSfbG55Fo5/awg+Dvlk2c39nTQc=; b=BII/ePzk4ZuTOuSqHJxN5z0IMwtmpB+vcfs1mIJIRiLyZVBmGwCvTxSporJ1bfnm yMxiXPhW4aoAwy+RRgEcZZxnnA5kparef/DjjHMLEeuxC5kiId29Dq4/MYdae9Wj0om IqaSM45h59bp+8drZhSIUilh+H44dFXi86skHNyM= Received: by mx.zohomail.com with SMTPS id 1756990548664140.47824642979833; Thu, 4 Sep 2025 05:55:48 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: [PATCH v3 06/14] rust: drm: gem: Add raw_dma_resv() function From: Daniel Almeida In-Reply-To: <20250829224116.477990-7-lyude@redhat.com> Date: Thu, 4 Sep 2025 09:55:30 -0300 Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Sumit Semwal , =?utf-8?Q?Christian_K=C3=B6nig?= , Asahi Lina , linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, "open list:DMA BUFFER SHARING FRAMEWORK:Keyword:bdma_(?:buf|fence|resv)b" ), "moderated list:DMA BUFFER SHARING FRAMEWORK:Keyword:bdma_(?:buf|fence|resv)b" ) Content-Transfer-Encoding: quoted-printable Message-Id: <4E13112B-6379-4466-8924-417AA6ACB228@collabora.com> References: <20250829224116.477990-1-lyude@redhat.com> <20250829224116.477990-7-lyude@redhat.com> To: Lyude Paul X-Mailer: Apple Mail (2.3826.700.81) X-ZohoMailClient: External > On 29 Aug 2025, at 19:35, Lyude Paul wrote: >=20 > For retrieving a pointer to the struct dma_resv for a given GEM = object. We > also introduce it in a new trait, BaseObjectPrivate, which we = automatically > implement for all gem objects and don't expose to users outside of the > crate. >=20 > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/gem/mod.rs | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs > index ec36cd9ea69ed..f901d4263ee87 100644 > --- a/rust/kernel/drm/gem/mod.rs > +++ b/rust/kernel/drm/gem/mod.rs > @@ -186,6 +186,18 @@ fn create_mmap_offset(&self) -> Result { >=20 > impl BaseObject for T {} >=20 > +/// Crate-private base operations shared by all GEM object classes. > +#[expect(unused)] > +pub(crate) trait BaseObjectPrivate: IntoGEMObject { > + /// Return a pointer to this object's dma_resv. > + fn raw_dma_resv(&self) -> *mut bindings::dma_resv { > + // SAFETY: `as_gem_obj()` always returns a valid pointer to = the base DRM gem object This apparently does not match the actual function call below anymore. > + unsafe { (*self.as_raw()).resv } > + } > +} > + > +impl BaseObjectPrivate for T {} > + > /// A base GEM object. > /// > /// Invariants > --=20 > 2.50.0 >=20