From: KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com
Subject: [PATCH RT] ipc: add a critical section in pipelined_receive
Date: Thu, 14 Jul 2011 22:08:53 +0700 [thread overview]
Message-ID: <4E1F0685.1000803@toshiba.co.jp> (raw)
This patch is for v2.6.33.9-rt31 to avoid a deadlock.
In POSIX message queue, if a sender process uses SCHED_FIFO and
has a higher priority than a receiver process, the sender will
be stuck at ipc/mqueue.c:446
445 while (ewp->state == STATE_PENDING)
446 cpu_relax();
Description of the problem
(receiver process)
1. receiver changes sender's state to STATE_PENDING (mqueue.c:832)
2. wake up sender process and "switch to sender" (mqueue.c:833)
Note: This context switch only happens in PREEMPT_RT kernel.
(sender process)
3. sender check the own state in above loop (mqueue.c:445-446)
*. receiver will never wake up and cannot change sender's state to
STATE_READY because sender has higher priority
Signed-off-by: Yoshitake Kobayashi <yoshitake.kobayashi@toshiba.co.jp>
---
ipc/mqueue.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index 01582e5..712d813 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -827,12 +827,17 @@ static inline void pipelined_receive(struct mqueue_inode_info *info)
wake_up_interruptible(&info->wait_q);
return;
}
+ /*
+ * Keep them in one critical section for PREEMPT_RT:
+ */
+ preempt_disable_rt();
msg_insert(sender->msg, info);
list_del(&sender->list);
sender->state = STATE_PENDING;
wake_up_process(sender->task);
smp_wmb();
sender->state = STATE_READY;
+ preempt_enable_rt();
}
SYSCALL_DEFINE5(mq_timedsend, mqd_t, mqdes, const char __user *, u_msg_ptr,
--
1.7.2.5
reply other threads:[~2011-07-14 15:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1F0685.1000803@toshiba.co.jp \
--to=yoshitake.kobayashi@toshiba.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®