mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: halfdog <me@halfdog.net>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] [57/99] exec: delay address limit change until point of no return
Date: Thu, 28 Jul 2011 19:27:06 +0000	[thread overview]
Message-ID: <4E31B80A.4050701@halfdog.net> (raw)
In-Reply-To: <20110728173124.GI8006@one.firstfloor.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This should be continuation of http://lkml.org/lkml/2011/7/27/488

Andi Kleen wrote:
> On Thu, Jul 28, 2011 at 07:52:57AM +0000, halfdog wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>> 
>> Hello Mr. Kleen,
>> 
>> I saw your posting on lkml. Currently, I have no deep enough 
>> understanding of kernel memory management, so do you think, that 
>> delaying could make a otherwise irrelevant timerace in exec arg
>> handling somehow problematic?
> 
> I guess it would be better to fix it. Can you post your analysis to
> linux-kernel@vger.kernel.org ?  Feel free to cc me.

Please see
https://bugzilla.kernel.org/show_bug.cgi?id=39222
for analysis (Timerace in sys_execve when copying argv/env data from
userspace)

Seems to be historic, but not critical timerace (POC available, but no
crash, mem-leaks, ..).

- From my opinion, it should be possible to make the argv ptr go over the
0xc0000000 kernel/user split on x86 architectures, but I do not know if
the patch in discussion would worsen the situation. Until now, I failed
to trouble the kernel using this.

- -- 
http://www.halfdog.net/
PGP: 156A AE98 B91F 0114 FE88  2BD8 C459 9386 feed a bee
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFOMbgIxFmThv7tq+4RAqckAJoCeYCAdrxzWk4UXWtklubfvGR1RwCeMG+J
Yj6zC0mawHkthGGA3kEPEa4=
=SLlm
-----END PGP SIGNATURE-----

       reply	other threads:[~2011-07-28 20:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4E311559.60402@halfdog.net>
     [not found] ` <20110728173124.GI8006@one.firstfloor.org>
2011-07-28 19:27   ` halfdog [this message]
2011-07-27 21:47 [PATCH] [0/99] 2.6.35.14 longterm review Andi Kleen
2011-07-27 21:48 ` [PATCH] [57/99] exec: delay address limit change until point of no return Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E31B80A.4050701@halfdog.net \
    --to=me@halfdog.net \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome