From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751060Ab1IUOJw (ORCPT ); Wed, 21 Sep 2011 10:09:52 -0400 Received: from mailhost.informatik.uni-hamburg.de ([134.100.9.70]:53826 "EHLO mailhost.informatik.uni-hamburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810Ab1IUOJu (ORCPT ); Wed, 21 Sep 2011 10:09:50 -0400 Message-ID: <4E79F00E.7030306@metafoo.de> Date: Wed, 21 Sep 2011 16:09:18 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20110818 Icedove/3.0.11 MIME-Version: 1.0 To: Axel Lin CC: linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org Subject: Re: [PATCH 3/4] ASoC: Staticise jz4740_pcm_new() References: <1316587205.2824.1.camel@phoenix> <1316587310.2824.3.camel@phoenix> In-Reply-To: <1316587310.2824.3.camel@phoenix> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/21/2011 08:41 AM, Axel Lin wrote: > It is not used outside this driver so no need to make the symbol global. > > Signed-off-by: Axel Lin Acked-by: Lars-Peter Clausen Thanks. > --- > sound/soc/jz4740/jz4740-pcm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/jz4740/jz4740-pcm.c b/sound/soc/jz4740/jz4740-pcm.c > index a7c9578..d1989cd 100644 > --- a/sound/soc/jz4740/jz4740-pcm.c > +++ b/sound/soc/jz4740/jz4740-pcm.c > @@ -299,7 +299,7 @@ static void jz4740_pcm_free(struct snd_pcm *pcm) > > static u64 jz4740_pcm_dmamask = DMA_BIT_MASK(32); > > -int jz4740_pcm_new(struct snd_soc_pcm_runtime *rtd) > +static int jz4740_pcm_new(struct snd_soc_pcm_runtime *rtd) > { > struct snd_card *card = rtd->card->snd_card; > struct snd_soc_dai *dai = rtd->cpu_dai;