From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757955Ab1I2UhE (ORCPT ); Thu, 29 Sep 2011 16:37:04 -0400 Received: from oproxy3-pub.bluehost.com ([69.89.21.8]:48893 "HELO oproxy3-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757940Ab1I2UhB (ORCPT ); Thu, 29 Sep 2011 16:37:01 -0400 Message-ID: <4E84D6EB.3020300@xenotime.net> Date: Thu, 29 Sep 2011 13:36:59 -0700 From: Randy Dunlap Organization: YPO4 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.22) Gecko/20110907 SUSE/3.1.14 Thunderbird/3.1.14 MIME-Version: 1.0 To: Andres Salomon CC: Stephen Rothwell , linux-next@vger.kernel.org, LKML , Andrew Morton , x86 maintainers , dsd@laptop.org Subject: Re: [PATCH] olpc: olpc-xo1-sci.c is an input driver, depends on INPUT References: <20110929165730.661cf28c9bb27b8a85432cd2@canb.auug.org.au> <4E84D259.5020008@xenotime.net> <20110929133446.40ff3250@queued.net> In-Reply-To: <20110929133446.40ff3250@queued.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/29/11 13:34, Andres Salomon wrote: > On Thu, 29 Sep 2011 13:17:29 -0700 > Randy Dunlap wrote: > >> From: Randy Dunlap >> >> Fix build errors when CONFIG_INPUT is disabled (shortened list): >> >> olpc-xo1-sci.c:(.text+0x1aee6): undefined reference to `input_event' >> olpc-xo1-sci.c:(.text+0x1b077): undefined reference to >> `input_unregister_device' olpc-xo1-sci.c:(.text+0x1b081): undefined >> reference to `input_free_device' >> arch/x86/built-in.o:olpc-xo1-sci.c:(.text+0x1b270): more undefined >> references to `input_event' follow >> olpc-xo1-sci.c:(.devinit.text+0x155): undefined reference to >> `input_allocate_device' olpc-xo1-sci.c:(.devinit.text+0x1a4): >> undefined reference to `input_register_device' >> >> Signed-off-by: Randy Dunlap >> Cc: Andres Salomon >> --- >> Found in linux-next but also applies to mainline. >> >> arch/x86/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- next-2011-0929.orig/arch/x86/Kconfig >> +++ next-2011-0929/arch/x86/Kconfig >> @@ -2052,7 +2052,7 @@ config OLPC_XO1_RTC >> >> config OLPC_XO1_SCI >> bool "OLPC XO-1 SCI extras" >> - depends on OLPC && OLPC_XO1_PM >> + depends on OLPC && OLPC_XO1_PM && INPUT >> select POWER_SUPPLY >> select GPIO_CS5535 >> select MFD_CORE > > Thanks! > > Hm. This might actually need a 'select INPUT' though, since > OLPC_XO1_SCI is bool while INPUT is tristate. Sigh, bool.. I try to avoid using "select", but you can resubmit the patch to do that if you must. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***