From: "Jan Beulich" <JBeulich@suse.com>
To: "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
<linux-kernel@vger.kernel.org>
Cc: "Dan Carpenter" <error27@gmail.com>, <xen-devel@lists.xensource.com>
Subject: Re: [Xen-devel] [PATCH 3/9] xen/pciback: Check if the device is found instead of blindly assuming so.
Date: Fri, 30 Sep 2011 08:50:05 +0100 [thread overview]
Message-ID: <4E8590CD0200007800058ABA@nat28.tlf.novell.com> (raw)
In-Reply-To: <1317325971-21603-4-git-send-email-konrad.wilk@oracle.com>
>>> On 29.09.11 at 21:52, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> Just in case it is not found, don't try to dereference it.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> drivers/xen/xen-pciback/pci_stub.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/xen/xen-pciback/pci_stub.c
> b/drivers/xen/xen-pciback/pci_stub.c
> index d985b65..55086e9 100644
> --- a/drivers/xen/xen-pciback/pci_stub.c
> +++ b/drivers/xen/xen-pciback/pci_stub.c
> @@ -222,6 +222,8 @@ void pcistub_put_pci_dev(struct pci_dev *dev)
> }
>
> spin_unlock_irqrestore(&pcistub_devices_lock, flags);
> + if (!found_psdev)
> + return;
If this happens, it's a bug (backend controller found the device, but
the generic backend code didn't), so I would say minimally a WARN_ON()
should be issued here.
Jan
>
> /*hold this lock for avoiding breaking link between
> * pcistub and xen_pcibk when AER is in processing
next prev parent reply other threads:[~2011-09-30 7:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 19:52 [PATCH] Xen bug-fixes for 3.2 (v1) Konrad Rzeszutek Wilk
2011-09-29 19:52 ` [PATCH 1/9] xen/pciback: Do not dereference psdev during printk when it is NULL Konrad Rzeszutek Wilk
2011-09-30 7:31 ` [Xen-devel] " Jan Beulich
2011-10-03 16:14 ` Konrad Rzeszutek Wilk
2011-09-29 19:52 ` [PATCH 2/9] xen/pciback: Return proper error code from sscanf Konrad Rzeszutek Wilk
2011-09-30 7:45 ` [Xen-devel] " Jan Beulich
2011-10-03 16:18 ` Konrad Rzeszutek Wilk
2011-09-29 19:52 ` [PATCH 3/9] xen/pciback: Check if the device is found instead of blindly assuming so Konrad Rzeszutek Wilk
2011-09-30 7:50 ` Jan Beulich [this message]
2011-09-29 19:52 ` [PATCH 4/9] xen/events: BUG() when we can't allocate our event->irq array Konrad Rzeszutek Wilk
2011-09-30 7:55 ` [Xen-devel] " Ian Campbell
2011-10-03 16:21 ` Konrad Rzeszutek Wilk
2011-09-29 19:52 ` [PATCH 5/9] xen/events: Don't check the info for NULL as it is already done Konrad Rzeszutek Wilk
2011-09-29 19:52 ` [PATCH 6/9] xen/irq: If we fail during msi_capability_init return proper error code Konrad Rzeszutek Wilk
2011-09-29 19:52 ` [PATCH 7/9] xen/xenbus: Check before dereferencing it Konrad Rzeszutek Wilk
2011-09-30 8:01 ` [Xen-devel] " Ian Campbell
2011-10-03 16:26 ` Konrad Rzeszutek Wilk
2011-09-29 19:52 ` [PATCH 8/9] xen/enlighten: Fix compile warnings Konrad Rzeszutek Wilk
2011-09-30 8:10 ` [Xen-devel] " Ian Campbell
2011-10-03 16:30 ` Konrad Rzeszutek Wilk
2011-09-29 19:52 ` [PATCH 9/9] xen/p2m/debugfs: Fix potential pointer exception Konrad Rzeszutek Wilk
2011-09-30 8:18 ` [Xen-devel] " Ian Campbell
2011-10-03 16:37 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8590CD0200007800058ABA@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=error27@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®