From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755457Ab1JDJPc (ORCPT ); Tue, 4 Oct 2011 05:15:32 -0400 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:32920 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755188Ab1JDJPa (ORCPT ); Tue, 4 Oct 2011 05:15:30 -0400 Message-ID: <4E8ACEAE.3040400@dsn.lapis-semi.com> Date: Tue, 04 Oct 2011 18:15:26 +0900 From: Tomoya MORINAGA User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: Grant Likely CC: spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com, kok.howg.ewe@intel.com, toshiharu-linux@dsn.okisemi.com Subject: Re: [PATCH 1/5] spi-topcliff-pch: add tx-memory clear after complete transmitting References: <1315295914-6862-1-git-send-email-tomoya-linux@dsn.okisemi.com> In-Reply-To: <1315295914-6862-1-git-send-email-tomoya-linux@dsn.okisemi.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Grant, 1 month has passed. You look very busy, right ? We've been long waiting for your accept. Could you review these patch series ? Thanks in advance. (2011/09/06 16:58), Tomoya MORINAGA wrote: > Currently, in case of reading date from SPI flash, > command is sent twice. > The cause is that tx-memory clear processing is missing . > This patch adds the tx-momory clear processing. > > Signed-off-by: Tomoya MORINAGA > --- > drivers/spi/spi-topcliff-pch.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c > index 540c290..1b98b7e 100644 > --- a/drivers/spi/spi-topcliff-pch.c > +++ b/drivers/spi/spi-topcliff-pch.c > @@ -839,6 +839,11 @@ static void pch_spi_start_transfer(struct pch_spi_data *data) > > dma_sync_sg_for_cpu(&data->master->dev, dma->sg_rx_p, dma->nent, > DMA_FROM_DEVICE); > + > + dma_sync_sg_for_cpu(&data->master->dev, dma->sg_tx_p, dma->nent, > + DMA_FROM_DEVICE); > + memset(data->dma.tx_buf_virt, 0, PAGE_SIZE); > + > async_tx_ack(dma->desc_rx); > async_tx_ack(dma->desc_tx); > kfree(dma->sg_tx_p); -- tomoya ROHM Co., Ltd.