mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	linux-kernel@vger.kernel.org, qi.wang@intel.com,
	yong.y.wang@intel.com, joel.clark@intel.com,
	kok.howg.ewe@intel.com
Subject: Re: [PATCH] pch_dma: Fix suspend issue
Date: Fri, 07 Oct 2011 14:54:22 +0900	[thread overview]
Message-ID: <4E8E940E.7040701@dsn.lapis-semi.com> (raw)
In-Reply-To: <1317963658.1573.2229.camel@vkoul-udesk3>

(2011/10/07 14:00), Vinod Koul wrote:
> How would changing the max number of descriptors fix the memory
> violation?
>

In probe of pch_dma,  you can see the following code.

	for (i = 0; i < nr_channels; i++) {

snip...

		pd_chan->membase = &regs->desc[i];

snip...

	}

Max value of nr_channels is 12 defined at pci_table.
So, this caused memory access violation.

-- 
tomoya
ROHM Co., Ltd.

  reply	other threads:[~2011-10-07  5:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04  7:27 Tomoya MORINAGA
2011-10-07  5:00 ` Vinod Koul
2011-10-07  5:54   ` Tomoya MORINAGA [this message]
2011-10-07  6:14     ` Vinod Koul
2011-10-07 10:33       ` Tomoya MORINAGA
2011-10-07 14:18         ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8E940E.7040701@dsn.lapis-semi.com \
    --to=tomoya-linux@dsn.lapis-semi.com \
    --cc=dan.j.williams@intel.com \
    --cc=joel.clark@intel.com \
    --cc=kok.howg.ewe@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qi.wang@intel.com \
    --cc=vinod.koul@intel.com \
    --cc=yong.y.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®