mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxim Uvarov <maxim.uvarov@oracle.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
	konrad.wilk@oracle.com
Subject: Re: [PATCH] XEN_DOMAIN_MEMORY options.
Date: Fri, 14 Oct 2011 17:43:37 -0700	[thread overview]
Message-ID: <4E98D739.4000705@oracle.com> (raw)
In-Reply-To: <4E98C8B1.20304@goop.org>

On 10/14/2011 04:41 PM, Jeremy Fitzhardinge wrote:
> On 10/14/2011 04:33 PM, Maxim Uvarov wrote:
>> On 10/14/2011 04:00 PM, Jeremy Fitzhardinge wrote:
>>> On 10/14/2011 03:36 PM, Maxim Uvarov wrote:
>>>> Hello,
>>>>
>>>> Please find here patches for XEN_MAX_DOMAIN_MEMORY:
>>>>
>>>> [PATCH 1/2] xen: Fix XEN_MAX_DOMAIN_MEMORY to be selectable
>>>> [PATCH 2/2] xen: Make XEN_MAX_DOMAIN_MEMORY have more sensible
>>>> defaults for 32-bit builds
>>>
>>> What's the rationale?
>>>
>>>       J
>>
>> The first patch is actually bug fix. You can not define just "int"
>> without description in Kconfig. As the result this option will not be
>> visible in menuconfig. Even if you will change it in .config make
>> oldconfig will set it up for default value. So you need to add any
>> description to it as all others int options have.
>
> No, that was deliberate, because I don't really think there's a need to
> change it.
>

 From that point of view it's not clear why this option is still in Kconfig?

Jeremy, can you please share more details about this? I see people are 
having troubles with this option and in different kernels I see 
different work arounds  for it. For example:
http://lists.xensource.com/archives/html/xen-devel/2011-01/msg01841.html

Maxim.
>>
>> Second patch is more optional and it's just suggestion to use for 32
>> bit more corresponding value.
>
> While it would be very silly to put 128GB of actual RAM on a 32-bit
> machine, systems can have non-contiguous RAM placed at high addresses,
> which would no longer be accessible.
>
>      J


  reply	other threads:[~2011-10-15  0:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-14 22:36 Maxim Uvarov
2011-10-14 22:36 ` [PATCH 1/2] xen: Fix XEN_MAX_DOMAIN_MEMORY to be selectable Maxim Uvarov
2011-10-14 22:36 ` [PATCH 2/2] xen: Make XEN_MAX_DOMAIN_MEMORY have more sensible defaults for 32-bit builds Maxim Uvarov
2011-10-14 23:00 ` [PATCH] XEN_DOMAIN_MEMORY options Jeremy Fitzhardinge
2011-10-14 23:33   ` Maxim Uvarov
2011-10-14 23:41     ` Jeremy Fitzhardinge
2011-10-15  0:43       ` Maxim Uvarov [this message]
2011-10-15 13:05         ` Konrad Rzeszutek Wilk
2011-10-15 16:42           ` Ian Campbell
2011-10-19 14:05             ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-10-19 14:04           ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E98D739.4000705@oracle.com \
    --to=maxim.uvarov@oracle.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome