From: Casey Schaufler <casey@schaufler-ca.com>
To: Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
James Morris <jmorris@namei.org>
Subject: Re: [PATCH] Smack: fix: invalid length set for the result of /smack/access
Date: Tue, 18 Oct 2011 12:07:23 -0700 [thread overview]
Message-ID: <4E9DCE6B.9060006@schaufler-ca.com> (raw)
In-Reply-To: <1318937668-3602-1-git-send-email-jarkko.j.sakkinen@gmail.com>
On 10/18/2011 4:34 AM, Jarkko Sakkinen wrote:
> Forgot to update simple_transaction_set() to take terminator
> character into account.
>
> Signed-off-by: Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Applied to git://gitorious.org/smack-next/kernel.git#master
commit d86b2b61d4dea614d6f319772a90a8f98b55ed67
> ---
> security/smack/smackfs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> index 5498c4a..381eecf 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -1514,7 +1514,7 @@ static ssize_t smk_write_access(struct file *file, const char __user *buf,
> data[0] = res == 0 ? '1' : '0';
> data[1] = '\0';
>
> - simple_transaction_set(file, 1);
> + simple_transaction_set(file, 2);
> return SMK_LOADLEN;
> }
>
prev parent reply other threads:[~2011-10-18 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 11:34 Jarkko Sakkinen
2011-10-18 19:07 ` Casey Schaufler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9DCE6B.9060006@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=jarkko.j.sakkinen@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®