From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: dledford@redhat.com
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, joe.korty@ccur.com,
amwang@redhat.com
Subject: Re: [PATCH 2/4] ipc/mqueue: switch back to using non-max values on create
Date: Wed, 26 Oct 2011 11:36:20 -0400 [thread overview]
Message-ID: <4EA828F4.90204@gmail.com> (raw)
In-Reply-To: <CAHGf_=obvkUN-JYVfbLueTV3hmobnV3jY86ukHo1E6d-3NDZxg@mail.gmail.com>
> NAK.
>
> Commit b231cca is 3 years old commit. It's too late to revert.
> Moreover Commit b231cca changed hardcoded limit to kernel knob,
> and this patch do reverse. Of course, latter direction changes almost
> always bring us compatibility issue.
>
> commit b231cca4381ee15ec99afbfb244fbc0324869927
> Author: Joe Korty <joe.korty@ccur.com>
> Date: Sat Oct 18 20:28:32 2008 -0700
>
> message queues: increase range limits
>
> The right way is to create new knob likes mqueue/msgsize_default
> and to separate default and maximum value.
I discussed with Doug a little. OK, I probably understand his motivation.
Now, I ack this series with a few reservation.
I'll post a few incremental patches for resolving compatibility issue.
next prev parent reply other threads:[~2011-10-26 15:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 22:30 Various cleanups and a couple fixes to ipc/mqueue Doug Ledford
2011-09-27 22:30 ` [PATCH 1/4] ipc/mqueue: cleanup definition names and locations Doug Ledford
2011-09-27 22:30 ` [PATCH 2/4] ipc/mqueue: switch back to using non-max values on create Doug Ledford
2011-10-25 0:56 ` KOSAKI Motohiro
2011-10-26 15:36 ` KOSAKI Motohiro [this message]
[not found] ` <4EA828E4.1070409@gmail.com>
2011-10-26 15:37 ` [PATCH 5/4] ipc/mqueue: revert bump up DFLT_*MAX KOSAKI Motohiro
2011-10-26 17:28 ` Doug Ledford
2011-10-27 16:41 ` Joe Korty
2011-10-26 15:37 ` [PATCH 6/4] ipc/mqueue: don't use kmalloc(KMALLOC_MAX_SIZE) KOSAKI Motohiro
2011-10-26 17:29 ` Doug Ledford
2011-10-27 16:41 ` Joe Korty
2011-10-26 15:38 ` [PATCH 7/4] ipc/mqueue: separate mqueue default value from maximum value KOSAKI Motohiro
2011-10-26 17:31 ` Doug Ledford
2011-10-27 16:44 ` Joe Korty
2011-09-27 22:30 ` [PATCH 3/4] ipc/mqueue: enforce hard limits Doug Ledford
2011-09-27 22:30 ` [PATCH 4/4] ipc/mqueue: update maximums for the mqueue subsystem Doug Ledford
2011-10-25 1:00 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA828F4.90204@gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=dledford@redhat.com \
--cc=joe.korty@ccur.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome