I demand that Pierre Ossman may or may not have written... > Hi Darren, > It has come to my attention that the current routine for setting power > is not compliant with the specification. As such, I'd like you to try > the following and see if removes the need for your patch: Your patch was mangled by Thunderbird. IME, it always does this; you should attach patches, not include them inline. Still, it was easy enough to apply the patch manually. > I'd appreciate if you could test this sooner rather than later as the merge > window is just around the corner. It doesn't work. After applying my patch and fixing up the rejects, it still doesn't work. I need to disable the first of the writeb() calls mentioned in the last hunk of your patch for it to work again. I have the impression that the hardware doesn't like the power-on bit not being set :-| ... hmm, it looks like there's a small bug in my patch: the label "out" needs to be before the last writeb() otherwise, if power is -1, no write will happen regardless. I'm attaching a fixed version along with an adapted version of your patch. Pierre, if you're happy to sign off the modified version of your patch, feel free to convert my not-yet-signed-off-by into a normal signed-off-by. -- | Darren Salt | linux or ds at | nr. Ashington, | Toon | RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army | (PGP 2.6, GPG keys) Break up a relationship. Buy a computer.