From: Paul Turner <pjt@google.com>
To: Il Han <corone.il.han@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: add the inline keyword to the prototype.
Date: Tue, 15 Nov 2011 23:28:49 -0800 [thread overview]
Message-ID: <4EC36631.8030805@google.com> (raw)
In-Reply-To: <1321380994-5768-1-git-send-email-corone.il.han@gmail.com>
On 11/15/2011 10:16 AM, Il Han wrote:
> The prototype has to agree with the definition.
> Add the inline keyword to the prototype also
>
Hmm... this would then cause the prototypes to disagree in the
!CONFIG_CFS_BANDWIDTH case.
Can you update?
> Signed-off-by: Il Han<corone.il.han@gmail.com>
> ---
> kernel/sched_fair.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
> index 5c9e679..c7c93d2 100644
> --- a/kernel/sched_fair.c
> +++ b/kernel/sched_fair.c
> @@ -306,7 +306,7 @@ find_matching_se(struct sched_entity **se, struct sched_entity **pse)
>
> #endif /* CONFIG_FAIR_GROUP_SCHED */
>
> -static void account_cfs_rq_runtime(struct cfs_rq *cfs_rq,
> +static __always_inline void account_cfs_rq_runtime(struct cfs_rq *cfs_rq,
> unsigned long delta_exec);
>
> /**************************************************************
> @@ -1052,7 +1052,7 @@ static void clear_buddies(struct cfs_rq *cfs_rq, struct sched_entity *se)
> __clear_buddies_skip(se);
> }
>
> -static void return_cfs_rq_runtime(struct cfs_rq *cfs_rq);
> +static __always_inline void return_cfs_rq_runtime(struct cfs_rq *cfs_rq);
>
> static void
> dequeue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)
next prev parent reply other threads:[~2011-11-16 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 18:16 Il Han
2011-11-16 7:28 ` Paul Turner [this message]
2011-11-16 9:00 ` Peter Zijlstra
2011-11-16 18:40 ` Paul Turner
2011-11-16 12:45 Il Han
2011-11-16 13:06 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC36631.8030805@google.com \
--to=pjt@google.com \
--cc=corone.il.han@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome