Re: [PATCH v7] hwmon: Add driver for EXYNOS4 TMU

[Donggeun Kim <dg77.kim@samsung.com>]

On 2011년 11월 16일 06:24, Guenter Roeck wrote:
> On Tue, 2011-11-15 at 15:34 -0500, Paul Bolle wrote:
>> (This is an attempt to do a bit of review after the fact. See, this
>> appears to be to the patch that ended up as commit
>> 9d97e5c81e15afaef65d00f077f863c94f750839 in the mainline tree. Since
>> that tree is at v3.2-rc2 now this might be in time for v3.2. If my
>> comments have merit, that is.)
>>
>> On Wed, 2011-09-07 at 18:49 +0900, Donggeun Kim wrote:
>>> This patch allows to read temperature
>>> from TMU(Thermal Management Unit) of SAMSUNG EXYNOS4 series of SoC.
>> [...]
>>> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
>>> index 0b62c3c..c6fb761 100644
>>> --- a/drivers/hwmon/Kconfig
>>> +++ b/drivers/hwmon/Kconfig
>>> @@ -303,6 +303,16 @@ config SENSORS_DS1621
>>>  	  This driver can also be built as a module.  If so, the module
>>>  	  will be called ds1621.
>>>  
>>> +config SENSORS_EXYNOS4_TMU
>>> +	tristate "Temperature sensor on Samsung EXYNOS4"
>>> +	depends on EXYNOS4_DEV_TMU
>>
>> It doesn't look like that Kconfig symbol is part of the tree just yet.
>> That means people will not be able to build this driver from the
>> mainline tree. Why is this dependency needed? In a (rather quick) scan
>> of the code of this driver I couldn't spot anything not yet available in
>> the tree.
>>
> I have to defer to the driver author for that. Maybe the dependency was
> renamed at some point, or removed altogether.
> 
The dependency will be renamed to 'ARCH_EXYNOS4'.

Thanks,
Donggeun