Re: lustre: question about lov_request.c

["Drokin, Oleg" <oleg.drokin@intel.com>]

Hello!

  You are right, set_pga seems to be a dead member. It was alive a once, but somehow not fully removed now,
  so it's safe to drop the whole if and also the struct member itself.
  set_oabufs could be dropped as well.

  Thanks.

Bye,
    Oleg
On Jun 7, 2015, at 4:11 PM, Julia Lawall wrote:

> Hello,
> 
> The function lov_finish_set in 
> drivers/staging/lustre/lustre/lov/lov_request.c contains the code:
> 
>       if (set->set_pga) {
>                int len = set->set_oabufs * sizeof(*set->set_pga);
>                OBD_FREE_LARGE(set->set_pga, len);
>        }
> 
> If I change the call to OBD_FREE_LARGE to kvfree, then len is not useful 
> any more.  But actually, at least with grep, I can't find anywhere that 
> either the set_pga field or the set_oabufs field is set.  Am I missing 
> something, or can the whole if be removed?  Can these two fields go too?
> 
> thanks,
> julia