From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Felipe Contreras <felipe.contreras@nokia.com>,
linux-main <linux-kernel@vger.kernel.org>,
Kalle Jokiniemi <kalle.jokiniemi@nokia.com>,
Heikki Krogerus <heikki.krogerus@nokia.com>,
Anton Vorontsov <cbouatmailru@gmail.com>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] Revert "ARM: RX-51: Enable isp1704 power on/off"
Date: Mon, 12 Dec 2011 09:09:20 +0200 [thread overview]
Message-ID: <4EE5A8A0.2010206@bitmer.com> (raw)
In-Reply-To: <CAMP44s0a6hcORZn8wDxHUJKxs=wjAmkhRfiT9kEA_MoDYeAmfg@mail.gmail.com>
On 12/07/2011 08:42 PM, Felipe Contreras wrote:
> On Wed, Dec 7, 2011 at 1:46 PM, Jarkko Nikula <jarkko.nikula@bitmer.com> wrote:
>> On 12/05/2011 07:31 PM, Felipe Contreras wrote:
>>> Should probably have CC'ed linux-omap.
>>>
>>> On Mon, Dec 5, 2011 at 7:23 PM, Felipe Contreras
>>> <felipe.contreras@nokia.com> wrote:
>>>> From: Felipe Contreras<felipe.contreras@gmail.com>
>>>>
>>>> This reverts commit 10299e2e4e3ed3b16503d4e04edd48b33083f4e2.
>>>>
>>>> This seems to break USB networking stuff.
>>>>
>> I don't think revert is needed since CONFIG_CHARGER_ISP1704=y should make it
>> working. Although I don't know do we really need to drive the ISP1704 into
>> reset in board-rx51-peripherals.c? Would it be better to leave gpio state as
>> it was set by the bootloader and let the driver to do reset sequence if
>> needed?
>>
>> http://marc.info/?l=linux-omap&m=130795363204884&w=2
> Nope, that's actually worst:
>
> Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab001
> Internal error: : 1028 [#1]
> Modules linked in:
Indeed yes. I checked that in 3.0 it still works but not in 3.1 so some
non isp1704_charger change has broke it as there hasn't been changes on it.
--
Jarkko
next prev parent reply other threads:[~2011-12-12 7:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 17:23 [PATCH 0/2] omap: rx51: fix USB networking Felipe Contreras
2011-12-05 17:23 ` [PATCH 1/2] isp1704_charger: fix missing check Felipe Contreras
2011-12-08 14:42 ` Heikki Krogerus
2012-01-06 2:02 ` Anton Vorontsov
2011-12-05 17:23 ` [PATCH 2/2] Revert "ARM: RX-51: Enable isp1704 power on/off" Felipe Contreras
2011-12-05 17:31 ` Felipe Contreras
2011-12-07 11:46 ` Jarkko Nikula
2011-12-07 18:42 ` Felipe Contreras
2011-12-12 7:09 ` Jarkko Nikula [this message]
2011-12-13 21:19 ` Felipe Contreras
2011-12-13 22:53 ` Felipe Balbi
2011-12-13 23:02 ` Felipe Contreras
2011-12-14 7:30 ` Felipe Balbi
2011-12-14 19:31 ` Felipe Contreras
2011-12-07 7:14 ` kalle.jokiniemi
2011-12-07 10:57 ` Felipe Contreras
2011-12-07 13:05 ` Heikki Krogerus
2011-12-07 18:43 ` Felipe Contreras
2011-12-07 19:31 ` Tony Lindgren
2011-12-07 19:56 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras
2011-12-08 14:40 ` Heikki Krogerus
2011-12-08 20:23 ` [PATCH v2] omap: rx51: fix USB Felipe Contreras
2011-12-10 8:37 ` Sebastian Reichel
2011-12-08 20:23 ` [PATCH] omap: rx51: initialize isp1704 properly Felipe Contreras
2011-12-12 19:44 ` Tony Lindgren
2011-12-13 20:00 ` Sebastian Reichel
2011-12-13 20:05 ` Felipe Contreras
2011-12-13 21:55 ` Tony Lindgren
2011-12-08 14:13 ` [PATCH 2/2] Revert "ARM: RX-51: Enable isp1704 power on/off" Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE5A8A0.2010206@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=cbouatmailru@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=felipe.contreras@nokia.com \
--cc=heikki.krogerus@nokia.com \
--cc=kalle.jokiniemi@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome