From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/8] KVM: MMU: do not add a nonpresent spte to rmaps of its child
Date: Mon, 19 Dec 2011 11:39:12 +0900 [thread overview]
Message-ID: <4EEEA3D0.9070703@oss.ntt.co.jp> (raw)
In-Reply-To: <4EEB1A41.7090902@linux.vnet.ibm.com>
(2011/12/16 19:15), Xiao Guangrong wrote:
> -static void mmu_page_add_parent_pte(struct kvm_vcpu *vcpu,
> - struct kvm_mmu_page *sp, u64 *parent_pte)
> +static void mmu_page_add_set_parent_pte(struct kvm_vcpu *vcpu,
> + struct kvm_mmu_page *sp,
> + u64 *parent_pte)
> {
> if (!parent_pte)
> return;
>
> + mmu_spte_set(parent_pte, __pa(sp->spt) | SHADOW_PAGE_TABLE);
> pte_list_add(vcpu, parent_pte,&sp->parent_ptes);
> }
There are a few prefixes in the kvm mmu code.
e.g. mmu_page_, kvm_mmu_, kvm_mmu_page_, ...
Sometimes we also use "sp".
How about deciding a consistent way from now on?
E.g.
if the function is static and for local use only, such a prefix
can be eliminated,
if it is used outside of mmu.c, kvm_mmu_ is needed,
we use sp for kvm_mmu_page,
...
(just an example)
Takuya
next prev parent reply other threads:[~2011-12-19 2:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 10:13 [PATCH 0/8] KVM: MMU: reduce the size of shadow page structure and some cleanup Xiao Guangrong
2011-12-16 10:13 ` [PATCH 1/8] KVM: MMU: combine unsync and unsync_children Xiao Guangrong
2011-12-19 2:25 ` Takuya Yoshikawa
2011-12-22 16:06 ` Marcelo Tosatti
2011-12-23 4:11 ` Xiao Guangrong
2012-01-09 11:16 ` Marcelo Tosatti
2012-01-10 4:45 ` Xiao Guangrong
2011-12-16 10:14 ` [PATCH 2/8] KVM: MMU: set the dirty bit for the upper shadow page Xiao Guangrong
2012-01-09 11:30 ` Marcelo Tosatti
2012-01-10 4:46 ` Xiao Guangrong
2011-12-16 10:15 ` [PATCH 3/8] KVM: MMU: do not add a nonpresent spte to rmaps of its child Xiao Guangrong
2011-12-19 2:39 ` Takuya Yoshikawa [this message]
2011-12-19 8:32 ` Avi Kivity
2011-12-16 10:16 ` [PATCH 4/8] KVM: MMU: drop unsync_child_bitmap Xiao Guangrong
2011-12-18 8:59 ` Avi Kivity
2011-12-23 4:04 ` Xiao Guangrong
2011-12-16 10:16 ` [PATCH 5/8] KVM: MMU: optimize walking unsync shadow page Xiao Guangrong
2011-12-16 10:17 ` [PATCH 6/8] KVM: MMU: optimize handing invlpg Xiao Guangrong
2011-12-16 10:18 ` [PATCH 7/8] KVM: MMU: remove the redundant get_written_sptes Xiao Guangrong
2012-01-09 11:33 ` Marcelo Tosatti
2011-12-16 10:18 ` [PATCH 8/8] KVM: MMU: remove PT64_SECOND_AVAIL_BITS_SHIFT Xiao Guangrong
2011-12-18 10:42 ` Avi Kivity
2011-12-23 4:07 ` Xiao Guangrong
2012-01-09 5:04 ` [PATCH 0/8] KVM: MMU: reduce the size of shadow page structure and some cleanup Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEEA3D0.9070703@oss.ntt.co.jp \
--to=yoshikawa.takuya@oss.ntt.co.jp \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®