From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752943Ab1LSTy3 (ORCPT ); Mon, 19 Dec 2011 14:54:29 -0500 Received: from smtp-outbound-1.vmware.com ([65.115.85.69]:32709 "EHLO smtp-outbound-1.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752393Ab1LSTy1 (ORCPT ); Mon, 19 Dec 2011 14:54:27 -0500 Message-ID: <4EEF95B3.9000204@vmware.com> Date: Mon, 19 Dec 2011 20:51:15 +0100 From: Thomas Hellstrom User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100624 Mandriva/3.0.5-0.1mdv2009.1 (2009.1) Thunderbird/3.0.5 MIME-Version: 1.0 To: Konrad Rzeszutek Wilk , Jerome Glisse CC: Thomas Hellstrom , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bskeggs@redhat.com Subject: Re: [PATCH] fixes to drm-next - TTM DMA code (v1) References: <1323720569-15435-1-git-send-email-konrad.wilk@oracle.com> <20111213160753.GC2339@homer.localdomain> <4EE77C02.1000103@vmware.com> <20111213164031.GA32052@phenom.dumpdata.com> In-Reply-To: <20111213164031.GA32052@phenom.dumpdata.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/13/2011 05:40 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 13, 2011 at 05:23:30PM +0100, Thomas Hellstrom wrote: > >> On 12/13/2011 05:07 PM, Jerome Glisse wrote: >> >>> On Mon, Dec 12, 2011 at 03:09:26PM -0500, Konrad Rzeszutek Wilk wrote: >>> >>>> Jerome pointed me to some accounting error in the DMA API debugging code and >>>> while I can't figure it out yet, I did notice some extreme slowness - which >>>> is due to the nouveau driver calling the unpopulate (now that unbind + >>>> unpopulate are squashed) quite a lot (this is using Gnome Shell - I think GNOME2 >>>> did not have those issues but I can't recall). >>>> >>>> Anyhow these patches fix the 50% perf regression I saw and also some minor bugs >>>> that I noticed. >>>> >>>> >>> Gonna review those today and test them. >>> >>> Cheers, >>> Jerome >>> >> Hi! >> >> I'm not whether any drivers are still using the AGP backend? >> > Uh, probably they do if the cards are AGP? > The problem I encountered was with an PCIe Nvidia card: > > 01:00.0 VGA compatible controller: nVidia Corporation G84 [GeForce 8600 GT] (rev a1 > > >> Calling unpopulate / (previous clear) each time unbind is done >> should be quite >> inefficient with that one, as AGP sets up its own data structures >> and copies page tables >> on each populate. That should really be avoided unless there is a >> good reason to have it. >> > nouveau_bo_rd32 and nv50_crtc_cursor_set showed up as the callers that > were causing the unpopulate calls. It did happen _a lot_ when I moved the > cursor madly. > Konrad, Jerome Was there a resolution to this. If the ttm_tt rewrite results in unpopulate being called more often than before, and that causes performance regressions, that must be fixed as soon as possible. /Thomas > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >