From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753015Ab1LSXHm (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 Dec 2011 18:07:42 -0500
Received: from mail-yx0-f174.google.com ([209.85.213.174]:56547 "EHLO
	mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752499Ab1LSXHi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 Dec 2011 18:07:38 -0500
Message-ID: <4EEFC3B7.9020008@gmail.com>
Date: Mon, 19 Dec 2011 15:07:35 -0800
From: David Daney <ddaney.cavm@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
MIME-Version: 1.0
To: ralf@linux-mips.org, Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mips@linux-mips.org,
        Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: linux-kernel@vger.kernel.org, Jason Baron <jbaron@redhat.com>,
        David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v2a] jump-label: initialize jump-label subsystem somewhat
 later
References: <1323885279-26850-1-git-send-email-ddaney.cavm@gmail.com>
In-Reply-To: <1323885279-26850-1-git-send-email-ddaney.cavm@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/14/2011 09:54 AM, David Daney wrote:
> From: David Daney<david.daney@cavium.com>
>
> commit 97ce2c88f9ad42e3c60a9beb9fca87abf3639faa
> (jump-label: initialize jump-label subsystem much earlier) breaks MIPS.
>
> The jump-label initialization does I-Cache flushing after modifying
> code.  On MIPS this is done by calling through the function pointer
> flush_icache_range().  This function pointer is initialized by
> trap_init().
>
> As things stand, we cannot be calling jump_label_init() until after
> trap_init() completes, so we move the call down to satisfy this
> constraint.
>
> Signed-off-by: David Daney<david.daney@cavium.com>

NACK to myself:

I now have a patch for MIPS that makes this one unnecessary.

David Daney

> ---
>
> Sorry for spamming this out again, but Sergei keeps flagging my poor
> grammar.
>
> Difference from v2: Fix grammar and spelling issues in changelog.  No
>                      change to the patch.
>
> Difference from v1: Move jump_label_init() up one so it is now before
>                      mm_init() instead of after it.
>
>
>   init/main.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/init/main.c b/init/main.c
> index 217ed23..68ab12b 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -513,8 +513,6 @@ asmlinkage void __init start_kernel(void)
>   		   __stop___param - __start___param,
>   		&unknown_bootoption);
>
> -	jump_label_init();
> -
>   	/*
>   	 * These use large bootmem allocations and must precede
>   	 * kmem_cache_init()
> @@ -524,6 +522,7 @@ asmlinkage void __init start_kernel(void)
>   	vfs_caches_init_early();
>   	sort_main_extable();
>   	trap_init();
> +	jump_label_init();
>   	mm_init();
>
>   	/*