From: Arun Sharma <asharma@fb.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
<linux-kernel@vger.kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Andrew Vagin <avagin@openvz.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/2] tracing, sched: Add delay info to sched_switch
Date: Mon, 19 Dec 2011 15:40:07 -0800 [thread overview]
Message-ID: <4EEFCB57.8080203@fb.com> (raw)
In-Reply-To: <1324337685.5916.47.camel@gandalf.stny.rr.com>
On 12/19/11 3:34 PM, Steven Rostedt wrote:
> On Tue, 2011-12-20 at 00:28 +0100, Peter Zijlstra wrote:
>> On Mon, 2011-12-19 at 15:23 -0800, Arun Sharma wrote:
>>> +#ifdef CONFIG_SCHEDSTATS
>>> + __entry->delay = next->se.statistics.block_start ? next->se.statistics.block_start
>>> + : next->se.statistics.sleep_start ? next->se.statistics.sleep_start : 0;
>>> + __entry->delay = __entry->delay ? now - __entry->delay : 0;
>>> +#else
>>> + __entry->delay = 0;
>>> +#endif
>>
>> I don't really like this, this should be one of those sched_*_stat
>> thingies, not sched_switch().
>
> Agreed.
How does:
sched_stat_sleeptime(current, now);
at the same point sound? I'll leave sched_switch() as is.
-Arun
prev parent reply other threads:[~2011-12-19 23:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 23:23 [PATCH 0/2] Sleep profiling Arun Sharma
2011-12-19 23:23 ` [PATCH 1/2] tracing, sched: move the sched_switch tracepoint Arun Sharma
2011-12-19 23:29 ` Peter Zijlstra
2011-12-19 23:36 ` Peter Zijlstra
2011-12-19 23:40 ` Mathieu Desnoyers
2011-12-19 23:23 ` [PATCH 2/2] tracing, sched: Add delay info to sched_switch Arun Sharma
2011-12-19 23:28 ` Peter Zijlstra
2011-12-19 23:34 ` Steven Rostedt
2011-12-19 23:40 ` Arun Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEFCB57.8080203@fb.com \
--to=asharma@fb.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=avagin@openvz.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome