From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754724Ab2ADJQq (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Jan 2012 04:16:46 -0500
Received: from nat28.tlf.novell.com ([130.57.49.28]:46134 "EHLO
	nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754522Ab2ADJQm convert rfc822-to-8bit (ORCPT
	<rfc822;groupwise-linux-kernel@vger.kernel.org:11:1>);
	Wed, 4 Jan 2012 04:16:42 -0500
Message-Id: <4F04273E020000780006A502@nat28.tlf.novell.com>
X-Mailer: Novell GroupWise Internet Agent 12.0.0 
Date: Wed, 04 Jan 2012 09:17:34 +0000
From: "Jan Beulich" <JBeulich@suse.com>
To: "Ian Campbell" <Ian.Campbell@citrix.com>,
        "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Cc: "Konrad Rzeszutek Wilk" <konrad@darnok.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
        "FlorianSchandinat@gmx.de" <FlorianSchandinat@gmx.de>,
        "Jeremy Fitzhardinge" <jeremy@goop.org>,
        "Jens Axboe" <axboe@kernel.dk>,
        "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
        "Ben Hutchings" <bhutchings@solarflare.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH, v2] Xen: consolidate and simplify struct
 xenbus_driver instantiation
References: <4EF3018D020000780006986E@nat28.tlf.novell.com>
 <1324547820.7877.71.camel@zakaz.uk.xensource.com>
 <4EF327E2020000780006993E@nat28.tlf.novell.com>
 <1324555060.7877.84.camel@zakaz.uk.xensource.com>
 <1324565067.2897.2.camel@bwh-desktop>
 <1324586301.13113.3.camel@dagon.hellion.org.uk>
 <20120103203637.GF17472@phenom.dumpdata.com>
In-Reply-To: <20120103203637.GF17472@phenom.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>> On 03.01.12 at 21:36, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> On Thu, Dec 22, 2011 at 08:38:21PM +0000, Ian Campbell wrote:
>> On Thu, 2011-12-22 at 14:44 +0000, Ben Hutchings wrote:
>> > On Thu, 2011-12-22 at 11:57 +0000, Ian Campbell wrote:
>> > > On Thu, 2011-12-22 at 11:51 +0000, Jan Beulich wrote:
>> > > > >>> On 22.12.11 at 10:57, Ian Campbell <Ian.Campbell@citrix.com> wrote:
>> > > > > On Thu, 2011-12-22 at 09:08 +0000, Jan Beulich wrote:
>> > > > >> The 'name', 'owner', and 'mod_name' members are redundant with the
>> > > > >> identically named fields in the 'driver' sub-structure. Rather than
>> > > > >> switching each instance to specify these fields explicitly, introduce
>> > > > >> a macro to simplify this.
>> > > > >> 
>> > > > >> Eliminate further redundancy by allowing the drvname argument to
>> > > > >> DEFINE_XENBUS_DRIVER() to be blank (in which case the first entry from
>> > > > >> the ID table will be used for .driver.name).
>> > > > > 
>> > > > > Any reason not to always use DRV_NAME here (which is generally a bit
>> > > > > more specific e.g. "xen-foofront" rather than "foo") and rely on the id
>> > > > > table for the shorter names used in xenstore?
>> > > > 
>> > > > That would imply that DRV_NAME is always defined, but I don't
>> > > > see this being the case.
>> > > 
>> > > My mistake, I thought it was a Kbuild thing.
>> > 
>> > You're maybe thinking of KBUILD_MODNAME.
>> 
>> Yes, I think I was.
> 
> Ian, are you OK with this patch? I think Jan needs to repost once more with 
> the
> "pciback" -> DRV_NAME change and then it is OK?

But that is what v2 was about (which is this thread).

Jan

> I've tested it with all backends, except the pciback one, and I see no 
> regressions
> with 'xl' or 'xm' toolstack.