mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: <alan@linux.intel.com>, <gregkh@suse.de>,
	<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: relocate remaining serial drivers from tty/ to tty/serial/
Date: Wed, 4 Jan 2012 17:43:55 -0500	[thread overview]
Message-ID: <4F04D62B.50107@windriver.com> (raw)
In-Reply-To: <20120104220158.3300d65b@pyramind.ukuu.org.uk>

On 12-01-04 05:01 PM, Alan Cox wrote:
> On Wed,  4 Jan 2012 15:01:27 -0500
> Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> 
>> The commit ab4382d27412e7e3e7c936e8d50d8888dfac3df8,
>>
>>    "tty: move drivers/serial/ to drivers/tty/serial/"
>>
>> put most of the serial drivers together in one place, but the ones
>> that were hiding in drivers/char didn't get picked up in that change.
>>
>> They did get moved in commit a6afd9f3e819de4795fcd356e5bfad446e4323f2
>>
>>    "tty: move a number of tty drivers from drivers/char/ to drivers/tty/"
>>
>> but there was no distinction of serial vs. non-serial in the above.
>>
>> Here we take the remaining serial drivers (mostly legacy multiport
>> drivers) and put them alongside all the others in tty/serial/ dir.
>>
>> We can drop SERIAL_NONSTANDARD's dependency on HAS_IOMEM, since the
>> encompassing menu block already has that dependency called out.
> 
> NAK
> 
> The tty/serial directory is the stuff using serial_core. I'm not averse
> to moving the others down a layer into more appropriate places but its
> already too crowded and in need of re-ordering (eg tty/serial/8250/...
> might be an improvement)

OK, I can do 8250.  What do you have in mind for the legacy multiport
drivers then, leave them as-in in drivers/tty or another subdir just
for them?

Thanks,
P.

> 

      reply	other threads:[~2012-01-04 22:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 20:01 Paul Gortmaker
2012-01-04 20:34 ` Jiri Slaby
2012-01-04 20:51   ` Greg KH
2012-01-04 21:07     ` Paul Gortmaker
2012-01-04 22:03       ` Greg KH
2012-01-04 23:27         ` Arnd Bergmann
2012-01-05  5:42           ` Sam Ravnborg
2012-01-05 12:45             ` Alan Cox
2012-01-05 23:21               ` Paul Gortmaker
2012-01-06 13:42                 ` Greg KH
2012-02-08 10:30                 ` Jiri Slaby
2012-02-08 10:32                   ` Jiri Slaby
2012-02-08 13:58                     ` Paul Gortmaker
2012-02-08 14:12                     ` Paul Gortmaker
2012-01-04 22:01 ` Alan Cox
2012-01-04 22:43   ` Paul Gortmaker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F04D62B.50107@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=alan@linux.intel.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome