From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932717Ab2AEPy7 (ORCPT ); Thu, 5 Jan 2012 10:54:59 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:51156 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932645Ab2AEPy4 (ORCPT ); Thu, 5 Jan 2012 10:54:56 -0500 Message-ID: <4F05C7CB.3000607@lwfinger.net> Date: Thu, 05 Jan 2012 09:54:51 -0600 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111220 Thunderbird/9.0 MIME-Version: 1.0 To: Stanislaw Gruszka CC: Joe Perches , Chaoming Li , "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] rtlwifi: Standardize RT_PRINT_DATA macro and uses References: <20120105114314.GD2222@redhat.com> In-Reply-To: <20120105114314.GD2222@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2012 05:43 AM, Stanislaw Gruszka wrote: > Hi Joe > > On Wed, Jan 04, 2012 at 07:40:40PM -0800, Joe Perches wrote: >> RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_DMESG, > > Since you are working on it, can you also get rid of this DBG_* > parameter, if rtlwifi maintainers are ok with that? It is additional > console loglvevel, standard kernel loglevel should be used. I'm not OK with that. Those DBG_* parameters are used in conjunction with a load-time debug parameter to set the level of debugging. You could rename all of them, but that would be useless churning of the source with no real value. Larry