From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751689Ab2AIJbZ (ORCPT ); Mon, 9 Jan 2012 04:31:25 -0500 Received: from nat28.tlf.novell.com ([130.57.49.28]:59826 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142Ab2AIJbX convert rfc822-to-8bit (ORCPT ); Mon, 9 Jan 2012 04:31:23 -0500 Message-Id: <4F0AC189020000780006B1DE@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.0 Date: Mon, 09 Jan 2012 09:29:29 +0000 From: "Jan Beulich" To: "Konrad Rzeszutek Wilk" Cc: "Ian Campbell" , "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "jbarnes@virtuousgeek.org" Subject: Re: [Xen-devel] [PATCH 4/5] xen/pciback: Expand the warning message to include domain id. References: <1325724403-29642-1-git-send-email-konrad.wilk@oracle.com> <1325724403-29642-5-git-send-email-konrad.wilk@oracle.com> <4F06C101020000780006AC32@nat28.tlf.novell.com> <20120106150338.GB5855@phenom.dumpdata.com> <1325865086.25206.512.camel@zakaz.uk.xensource.com> <20120106160011.GD6125@phenom.dumpdata.com> <20120106221927.GA10248@phenom.dumpdata.com> In-Reply-To: <20120106221927.GA10248@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 06.01.12 at 23:19, Konrad Rzeszutek Wilk wrote: >> > I suppose you might want "Overriding ownership to dom%d". >> >> OK. To the point and potentially can fit in 80 lines :-). > > how about this? >> > From a3d4a80cdfd4274016522572148a89260b3f3de6 Mon Sep 17 00:00:00 2001 > From: Konrad Rzeszutek Wilk > Date: Wed, 4 Jan 2012 14:16:45 -0500 > Subject: [PATCH] xen/pciback: Expand the warning message to include domain > id. > > When a PCI device is transferred to another domain and it is still > in usage (from the internal perspective), mention which other > domain is using it to aid in debugging. > > [v2: Truncate the verbose message per Jan Beulich suggestion] > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Jan Beulich > --- > drivers/xen/xen-pciback/xenbus.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c > index 474d52e..2405a24 100644 > --- a/drivers/xen/xen-pciback/xenbus.c > +++ b/drivers/xen/xen-pciback/xenbus.c > @@ -243,8 +243,8 @@ static int xen_pcibk_export_device(struct > xen_pcibk_device *pdev, > dev_dbg(&dev->dev, "registering for %d\n", pdev->xdev->otherend_id); > if (xen_register_device_domain_owner(dev, > pdev->xdev->otherend_id) != 0) { > - dev_err(&dev->dev, "device has been assigned to another " \ > - "domain! Over-writting the ownership, but beware.\n"); > + dev_err(&dev->dev, "Overriding ownership to dom%d.\n", > + xen_find_device_domain_owner(dev)); > xen_unregister_device_domain_owner(dev); > xen_register_device_domain_owner(dev, pdev->xdev->otherend_id); > } > -- > 1.7.7.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel