mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: <mingo@elte.hu>,
	"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
	<tglx@linutronix.de>, <luca@luca-barbieri.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ix86: atomic64 assembly improvements
Date: Thu, 19 Jan 2012 14:50:34 +0000	[thread overview]
Message-ID: <4F183BCA020000780006DB68@nat28.tlf.novell.com> (raw)
In-Reply-To: <4F182C55.7040305@zytor.com>

>>> On 19.01.12 at 15:44, "H. Peter Anvin" <hpa@zytor.com> wrote:
> On 01/19/2012 01:18 AM, Jan Beulich wrote:
>> 
>> But the code is supposed to be correct even when caches are disabled
>> (in which case LOCK# will continue to be used even on modern CPUs),
>> and this case clearly isn't covered by the current implementation. It
>> may be a good idea to adjust the patch description accordingly, but I
>> see no reason to change the patch itself.
>> 
> 
> It doesn't have anything to do with caches on or off.

How does it not? If any part of the bus topology is only 32 bits wide,
a 64-bit read or write simply can't be executed atomically without
asserting LOCK#.

Jan


  reply	other threads:[~2012-01-19 14:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18 14:24 Jan Beulich
2012-01-18 16:36 ` H. Peter Anvin
2012-01-18 16:50   ` Jan Beulich
2012-01-18 17:47     ` H. Peter Anvin
2012-01-19  9:18       ` Jan Beulich
2012-01-19 14:44         ` H. Peter Anvin
2012-01-19 14:50           ` Jan Beulich [this message]
2012-01-19 14:55             ` H. Peter Anvin
2012-01-19 14:59             ` H. Peter Anvin
2012-01-19 15:11               ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F183BCA020000780006DB68@nat28.tlf.novell.com \
    --to=jbeulich@suse.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@luca-barbieri.com \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®