From: Martyn Welch <martyn.welch@ge.com>
To: Sam Hansen <solid.se7en@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Manohar Vanga <manohar.vanga@cern.ch>,
Vincent Bossier <vincent.bossier@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Emilio G. Cota" <cota@braap.org>
Subject: Re: [PATCH 1/1] vme: code convention fix
Date: Fri, 20 Jan 2012 09:46:17 +0000 [thread overview]
Message-ID: <4F1937E9.3030409@ge.com> (raw)
In-Reply-To: <1327050687-8907-1-git-send-email-solid.se7en@gmail.com>
On 20/01/12 09:11, Sam Hansen wrote:
> Fixed a code convention violation in vme.h
>
> Signed-off-by: Sam Hansen <solid.se7en@gmail.com>
Huh, wonder how that got missed when I ran checkpatch over these files.
Good catch,
Acked-by: Martyn Welch <martyn.welch@ge.com>
> ---
> drivers/staging/vme/vme.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/vme/vme.h b/drivers/staging/vme/vme.h
> index 9d38cee..c9d65bf 100644
> --- a/drivers/staging/vme/vme.h
> +++ b/drivers/staging/vme/vme.h
> @@ -156,7 +156,7 @@ int vme_irq_request(struct vme_dev *, int, int,
> void vme_irq_free(struct vme_dev *, int, int);
> int vme_irq_generate(struct vme_dev *, int, int);
>
> -struct vme_resource * vme_lm_request(struct vme_dev *);
> +struct vme_resource *vme_lm_request(struct vme_dev *);
> int vme_lm_count(struct vme_resource *);
> int vme_lm_set(struct vme_resource *, unsigned long long, u32, u32);
> int vme_lm_get(struct vme_resource *, unsigned long long *, u32 *, u32 *);
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E martyn.welch@ge.com | VAT:GB 927559189
prev parent reply other threads:[~2012-01-20 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 9:11 Sam Hansen
2012-01-20 9:46 ` Martyn Welch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1937E9.3030409@ge.com \
--to=martyn.welch@ge.com \
--cc=cota@braap.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@cern.ch \
--cc=solid.se7en@gmail.com \
--cc=vincent.bossier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome