From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: rjw@sisk.pl, linux-kernel <linux-kernel@vger.kernel.org>,
Linux PM mailing list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 3.3-rc1] PM / Sleep: Fix read_unlock_usermodehelper() call.
Date: Mon, 23 Jan 2012 11:19:18 +0530 [thread overview]
Message-ID: <4F1CF4DE.5090207@linux.vnet.ibm.com> (raw)
In-Reply-To: <201201230449.q0N4npAa029457@www262.sakura.ne.jp>
On 01/23/2012 10:19 AM, Tetsuo Handa wrote:
> Commit b298d289
> "PM / Sleep: Fix freezer failures due to racy usermodehelper_is_disabled()"
> added read_unlock_usermodehelper() but read_unlock_usermodehelper() is called
> without read_lock_usermodehelper() when kmalloc() failed.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> -----
Acked-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Thanks for catching this!
Regards,
Srivatsa S. Bhat
> diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
> index 26ab358..6c9387d 100644
> --- a/drivers/base/firmware_class.c
> +++ b/drivers/base/firmware_class.c
> @@ -525,8 +525,7 @@ static int _request_firmware(const struct firmware **firmware_p,
> if (!firmware) {
> dev_err(device, "%s: kmalloc(struct firmware) failed\n",
> __func__);
> - retval = -ENOMEM;
> - goto out;
> + return -ENOMEM;
> }
>
> if (fw_get_builtin_firmware(firmware, name)) {
>
next parent reply other threads:[~2012-01-23 5:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201201230449.q0N4npAa029457@www262.sakura.ne.jp>
2012-01-23 5:49 ` Srivatsa S. Bhat [this message]
2012-01-23 21:09 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1CF4DE.5090207@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome