mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: linux-kernel@vger.kernel.org, broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] regulator: mc13xxx-regulator-core: Fix the build when driver is selected as module
Date: Tue, 24 Jan 2012 14:19:49 -0800	[thread overview]
Message-ID: <4F1F2E85.1010505@xenotime.net> (raw)
In-Reply-To: <1327437436-10937-1-git-send-email-fabio.estevam@freescale.com>

On 01/24/2012 12:37 PM, Fabio Estevam wrote:
> Fix the following build error when mc138xxx driver is built as module:
> 
> ERROR: "mc13xxx_parse_regulators_dt" [drivers/regulator/mc13892-regulator.ko] undefined!
> ERROR: "mc13xxx_get_num_regulators_dt" [drivers/regulator/mc13892-regulator.ko] undefined!
> 
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.

> ---
>  drivers/regulator/mc13xxx-regulator-core.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
> index 80ecafe..62dcd0a 100644
> --- a/drivers/regulator/mc13xxx-regulator-core.c
> +++ b/drivers/regulator/mc13xxx-regulator-core.c
> @@ -254,6 +254,7 @@ int __devinit mc13xxx_get_num_regulators_dt(struct platform_device *pdev)
>  
>  	return num;
>  }
> +EXPORT_SYMBOL_GPL(mc13xxx_get_num_regulators_dt);
>  
>  struct mc13xxx_regulator_init_data * __devinit mc13xxx_parse_regulators_dt(
>  	struct platform_device *pdev, struct mc13xxx_regulator *regulators,
> @@ -291,6 +292,7 @@ struct mc13xxx_regulator_init_data * __devinit mc13xxx_parse_regulators_dt(
>  
>  	return data;
>  }
> +EXPORT_SYMBOL_GPL(mc13xxx_parse_regulators_dt);
>  #endif
>  
>  MODULE_LICENSE("GPL v2");


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

      parent reply	other threads:[~2012-01-24 21:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-24 20:37 Fabio Estevam
2012-01-24 20:49 ` Mark Brown
2012-01-24 22:19 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1F2E85.1010505@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=fabio.estevam@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome