From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Danny Kukawka <danny.kukawka@bisect.de>
Cc: linux-kernel@vger.kernel.org,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] dmaengine: dmatest: fix thread_count
Date: Thu, 26 Jan 2012 16:58:07 +0100 [thread overview]
Message-ID: <4F21780F.7060504@atmel.com> (raw)
In-Reply-To: <1327592025-2461-1-git-send-email-danny.kukawka@bisect.de>
On 01/26/2012 04:33 PM, Danny Kukawka :
> It seems with commit f1aef8b6e6abf32a3a269542f95a19e2cb319f6c
> another case where thread_count wasn't calculated correctly
> has been overlooked.
>
> This fix also a -Wparentheses compiler warning.
>
> Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/dma/dmatest.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index 2b8661b..24225f0 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -599,7 +599,7 @@ static int dmatest_add_channel(struct dma_chan *chan)
> }
> if (dma_has_cap(DMA_PQ, dma_dev->cap_mask)) {
> cnt = dmatest_add_threads(dtc, DMA_PQ);
> - thread_count += cnt > 0 ?: 0;
> + thread_count += cnt > 0 ? cnt : 0;
> }
>
> pr_info("dmatest: Started %u threads using %s\n",
--
Nicolas Ferre
next prev parent reply other threads:[~2012-01-26 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 15:33 Danny Kukawka
2012-01-26 15:58 ` Nicolas Ferre [this message]
2012-01-26 16:07 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F21780F.7060504@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=dan.j.williams@intel.com \
--cc=danny.kukawka@bisect.de \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®