From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755249Ab2A0VXD (ORCPT ); Fri, 27 Jan 2012 16:23:03 -0500 Received: from tx2ehsobe003.messaging.microsoft.com ([65.55.88.13]:18444 "EHLO TX2EHSOBE005.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147Ab2A0VXC (ORCPT ); Fri, 27 Jan 2012 16:23:02 -0500 X-SpamScore: -9 X-BigFish: VS-9(zz1432N98dKzz1202hzzz2dhc1bhc31hc1ah2a8h668h839h) X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI Message-ID: <4F2315B0.2010507@freescale.com> Date: Fri, 27 Jan 2012 15:22:56 -0600 From: Timur Tabi Organization: Freescale User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0.1) Gecko/20111221 Firefox/9.0.1 SeaMonkey/2.6.1 MIME-Version: 1.0 To: Dmitry Artamonow CC: , Kumar Gala , Wim Van Sebroeck , Subject: Re: [PATCH] watchdog: fix GETTIMEOUT ioctl in booke_wdt References: <1327605870-9226-1-git-send-email-mad_soft@inbox.ru> <4F231234.5030007@freescale.com> In-Reply-To: <4F231234.5030007@freescale.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Timur Tabi wrote: > Dmitry Artamonow wrote: >> +#ifdef CONFIG_FSL_BOOKE >> + return put_user(period_to_sec(booke_wdt_period), p); >> +#else > > period_to_sec() returns an unsigned long long, which means that the driver > will write 8 bytes instead of 4 to user space. Ok, I take that back. put_user() uses the size of the pointer, which makes more sense anyway. -- Timur Tabi Linux kernel developer at Freescale