From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@osdl.org>, "Martin J. Bligh" <mbligh@aracnet.com>
Cc: dhowells@redhat.com, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Permit inode & dentry hash tables to be allocated > MAX_ORDER size
Date: Sat, 12 Jun 2004 13:45:08 +0100 [thread overview]
Message-ID: <4F2B7A16061839F525FD5279@[192.168.0.7]> (raw)
In-Reply-To: <20040611163051.6e7985bb.akpm@osdl.org>
--On 11 June 2004 16:30 -0700 Andrew Morton <akpm@osdl.org> wrote:
> Doesn't look that way. It uses
>
> (zone->zone_mem_map - page) >> (1 + order)
Hmmm, yes. Does this not mean that we will violate the object size N will be aligned at size N. Presumably that's why the error says 'it'll crash'. If we are two pages offset we will allocate 4 page objects 2 page aligned. I'll have a closer look and see if we can just 'round down' the zone_mem_map pointer here to give the correct alignment. As long as we don't try and free them into the allocator originally we should be ok, as they are marked allocated in the bitmaps at the start.
-apw
next prev parent reply other threads:[~2004-06-12 12:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-11 10:44 David Howells
2004-06-11 10:48 ` Andrew Morton
2004-06-11 11:12 ` David Howells
2004-06-11 22:04 ` Andrew Morton
2004-06-11 23:03 ` Martin J. Bligh
2004-06-11 23:19 ` Andrew Morton
2004-06-11 23:18 ` Martin J. Bligh
2004-06-11 23:30 ` Andrew Morton
2004-06-12 12:45 ` Andy Whitcroft [this message]
2004-06-13 16:09 ` Linus Torvalds
2004-06-11 14:21 ` [PATCH] Permit inode & dentry hash tables to be allocated > MAX_ORDER size [#2] David Howells
2004-06-11 22:01 ` Andrew Morton
2004-06-14 10:47 ` [PATCH] Permit inode & dentry hash tables to be allocated > MAX_ORDER size [try #3] David Howells
2004-06-14 11:04 ` Andrew Morton
2004-06-14 11:41 ` David Howells
[not found] <263jX-5RZ-19@gated-at.bofh.it>
[not found] ` <262nZ-56Z-5@gated-at.bofh.it>
[not found] ` <263jX-5RZ-17@gated-at.bofh.it>
2004-06-12 0:21 ` [PATCH] Permit inode & dentry hash tables to be allocated > MAX_ORDER size Andi Kleen
2004-06-12 6:00 ` Martin J. Bligh
2004-06-12 7:36 ` Dave Hansen
2004-06-12 13:11 ` Andi Kleen
2004-06-12 15:00 ` Martin J. Bligh
2004-06-15 16:40 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='4F2B7A16061839F525FD5279@[192.168.0.7]' \
--to=apw@shadowen.org \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®