From: "Jan Beulich" <JBeulich@suse.com>
To: "Dan Magenheimer" <dan.magenheimer@oracle.com>
Cc: "Jeremy Fitzhardinge" <jeremy@goop.org>,
<xen-devel@lists.xensource.com>,
"Konrad Wilk" <konrad.wilk@oracle.com>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] xen/tmem: cleanup
Date: Mon, 06 Feb 2012 08:12:34 +0000 [thread overview]
Message-ID: <4F2F998202000078000714CD@nat28.tlf.novell.com> (raw)
In-Reply-To: <d86f0be9-1530-47bd-b3fd-8c251e563b25@default>
>>> On 04.02.12 at 17:42, Dan Magenheimer <dan.magenheimer@oracle.com> wrote:
>> From: Jan Beulich [mailto:JBeulich@suse.com]
>> Subject: [PATCH] xen/tmem: cleanup
>>
>> Use 'bool' for boolean variables. Do proper section placement.
>> Eliminate an unnecessary export.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Cc: Dan Magenheimer <dan.magenheimer@oracle.com>
>>
>> -int tmem_enabled __read_mostly;
>> -EXPORT_SYMBOL(tmem_enabled);
>> +bool __read_mostly tmem_enabled = false;
>
> tmem_enabled is used in xen/drivers/xen-selfballoon.c
Which can't be built as a module, and hence the symbol doesn't need
exporting. This patch (of course, I'm tempted to say) survived build
testing.
Jan
next prev parent reply other threads:[~2012-02-06 8:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 15:09 Jan Beulich
2012-02-04 16:42 ` Dan Magenheimer
2012-02-06 8:12 ` Jan Beulich [this message]
2012-02-06 16:37 ` Dan Magenheimer
2012-02-06 16:49 ` Jan Beulich
2012-02-06 17:02 ` Konrad Rzeszutek Wilk
2012-02-06 17:22 ` Dan Magenheimer
2012-02-09 20:15 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-02-07 7:51 ` Jan Beulich
2012-02-07 10:23 ` [Xen-devel] " Vasiliy Tolstov
2012-02-09 20:40 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2F998202000078000714CD@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=dan.magenheimer@oracle.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®