From: Adam Jackson <ajax@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH] char/mem: Make /dev/port less obviously broken (v0)
Date: Mon, 06 Feb 2012 22:57:20 -0500 [thread overview]
Message-ID: <4F30A120.2050208@redhat.com> (raw)
In-Reply-To: <20120207001558.GA30840@kroah.com>
On 2/6/12 7:15 PM, Greg KH wrote:
> Who would use this new ioctl? And if it's been working ok until now,
> why is it needed?
I'll go out on a limb and say nobody's been seriously using /dev/port.
libpciaccess would like to, since it avoids needing iopl, and also
avoids duplicating all the kernel's per-arch logic for port access in
userspace. But if it's not going to give me the cycle size I asked for
I need to fix it before I can use it. Otherwise you get what I'm
getting, which is a vesa driver that doesn't work.
Adding the ioctl was just me being polite and assuming that user-kernel
ABI was a thing we actually believe in. If it's not, great, let's just
fix /dev/port to not be idiotic. If it is, I'd prefer not wasting the
memory on another inode.
> If you want something "new" like this, why not just create /dev/ioport
> or something like that to always use the proper alignment and not need
> an ioctl at all?
If you really want that shed painted a different color, fine.
- ajax
prev parent reply other threads:[~2012-02-07 3:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 23:02 Adam Jackson
2012-02-07 0:15 ` Greg KH
2012-02-07 3:57 ` Adam Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F30A120.2050208@redhat.com \
--to=ajax@redhat.com \
--cc=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome