From: "H. Peter Anvin" <hpa@zytor.com>
To: Bobby Powers <bobbypowers@gmail.com>
Cc: linux-kernel@vger.kernel.org, dhowells@redhat.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH tip/x86/x32] fs: fix close_on_exec pointer in alloc_fdtable
Date: Thu, 23 Feb 2012 06:56:50 -0800 [thread overview]
Message-ID: <4F4653B2.6000306@zytor.com> (raw)
In-Reply-To: <CAArOQ2U5CUiZ++RQdaB_AZSWKof4BM1Sbr=GihMRbH-kj_DGAQ@mail.gmail.com>
On 02/23/2012 06:40 AM, Bobby Powers wrote:
> On Wed, Feb 22, 2012 at 5:18 AM, David Howells<dhowells@redhat.com> wrote:
>> Bobby Powers<bobbypowers@gmail.com> wrote:
>>
>>> alloc_fdtable allocates space for the open_fds and close_on_exec
>>> bitfields together, as 2 * nr / BITS_PER_BYTE. close_on_exec needs to
>>> point to open_fds + nr / BITS_PER_BYTE, not open_fds + nr /
>>> BITS_PER_LONG, as introducted in 1fd36adc: Replace the fd_sets in
>>> struct fdtable with an array of unsigned longs.
>>>
>>> Signed-off-by: Bobby Powers<bobbypowers@gmail.com>
>>
>> Yes, you're right. At one point I changed data to be an unsigned long *.
>>
>> Acked-by: David Howells<dhowells@redhat.com>
>
> Thanks, its nice to have confirmation - I'm still pretty new at this.
> Can this get pulled onto tip/x86/x32? Desktop applications like
> firefox and chrome don't work reliably without it.
>
tip:core/types (and the updated core/types needs to be merged into
x86/x32) but yes.
-hpa
next prev parent reply other threads:[~2012-02-23 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 5:29 Bobby Powers
2012-02-22 10:18 ` David Howells
2012-02-23 14:40 ` Bobby Powers
2012-02-23 14:56 ` H. Peter Anvin [this message]
2012-02-24 2:42 ` [tip:core/types] fs: Fix " tip-bot for Bobby Powers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4653B2.6000306@zytor.com \
--to=hpa@zytor.com \
--cc=bobbypowers@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome