From: "Jan Beulich" <JBeulich@suse.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] consolidate WARN_...ONCE() static variables
Date: Tue, 28 Feb 2012 08:58:58 +0000 [thread overview]
Message-ID: <4F4CA56202000078000751EF@nat28.tlf.novell.com> (raw)
In-Reply-To: <20120228003206.e661f926.akpm@linux-foundation.org>
>>> On 28.02.12 at 09:32, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 28 Feb 2012 08:16:40 +0000 "Jan Beulich" <JBeulich@suse.com> wrote:
>
>> Oh, sorry - to carry static data the accesses to which are unlikely
>> (i.e., as in the case given, fully contained in code sections inside
>> conditionals which themselves use unlikely() on their primary/only
>> clause - in other words, something that the compiler really could
>> do on its own).
>
> I think I just learned more about this patch than at any time since we
> started discussing it.
>
> Why add a new section, rather than using __read_mostly?
Because __read_mostly data frequently is hot.
> I suppose we should add and use a #define for this, like __read_mostly.
> That would be a good site for documenting it ;)
That's a possibility of course. I'll do so in an eventual v3.
> And I come back to my old friend printk_once(). If I'm understanding
> things correctly, we can/should make that test unlikely, then mark
> __print_once as __this_new_section? Otherwise... help!
No. The variable itself serves for the tested condition here, and
hence a priori you can't say whether the whole construct sits in
a hot path (whether putting it in a hot path is a good idea is
another question, but the print-this-one-time-only nature of it
may be the very reason why someone considers this reasonable
for his code).
As opposed to that, the access to the static variable in WARN_ONCE()
is *after* an unlikely() condition was already evaluated, i.e. would
generally sit on a code path that we hope doesn't get speculated
along (often), by means of the compiler suitably arranging branch
targets.
> btw, I don't think there's a significant performance benefit here - if
> the kernel is ever executing WARN_ON_ONCE(), WARN_ONCE() or
> printk_once() with any frequency then it is already badly broken.
The intended performance benefit isn't with the WARN_ONCE()
constructs - we certainly don't care much about them being executed
efficiently - but instead with code path accessing other data in the
same cache line (or spilled across multiple cache lines just because
of the __warned variable sitting in the middle).
> Which brings us down to saving a bit of space. And I don't think I see
> how this saves space?
The space saving results from grouping (many) 1-byte entities
together, which (when emitted normally) will generally require
padding to 4 or 8 bytes (as being adjacent with other static data
in the same or next compilation unit). That padding won't occur
if all of the items in a given section are of the same size (and
alignment).
Jan
next prev parent reply other threads:[~2012-02-28 8:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 15:10 Jan Beulich
2012-02-28 0:03 ` Andrew Morton
2012-02-28 7:41 ` Jan Beulich
2012-02-28 7:44 ` Andrew Morton
2012-02-28 8:02 ` Jan Beulich
2012-02-28 8:12 ` Andrew Morton
2012-02-28 8:16 ` Jan Beulich
2012-02-28 8:32 ` Andrew Morton
2012-02-28 8:58 ` Jan Beulich [this message]
2012-02-28 21:19 ` Andrew Morton
2012-02-29 8:21 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4CA56202000078000751EF@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®