From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
David Miller <davem@davemloft.net>,
"andrei.emeltchenko.news@gmail.com"
<andrei.emeltchenko.news@gmail.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] checkpatch: Add some --strict coding style checks
Date: Wed, 29 Feb 2012 16:38:05 +0200 [thread overview]
Message-ID: <4F4E384D.2090802@qca.qualcomm.com> (raw)
In-Reply-To: <1330108675.18464.21.camel@joe2Laptop>
On 02/24/2012 08:37 PM, Joe Perches wrote:
> Argument alignment across multiple lines should
> match the open parenthesis.
>
> Logical continuations should be at the end of
> the previous line, not the start of a new line.
>
> These are not required by CodingStyle so make the
> tests active only when using --strict.
>
> Improved_by_examples_from: "Bruce W. Allen" <bruce.w.allan@intel.com>
> Signed-off-by: Joe Perches <joe@perches.com>
Thanks Joe, this is very useful for me. I seem to have one false alarm
though:
drivers/net/wireless/ath/ath6kl/txrx.c:464: CHECK: Alignment should
match open parenthesis
This is with patches I haven't sent yet so line numbers most likely
don't match, but the code in question is this:
if (!IS_ALIGNED((unsigned long) skb->data - HTC_HDR_LENGTH, 4) &&
skb_cloned(skb)) {
Apparently the cast "(unsigned long)" causes the false alarm as when I
remove it I don't see the warning anymore.
Kalle
next prev parent reply other threads:[~2012-02-29 14:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 20:37 pull request: wireless 2012-02-20 John W. Linville
2012-02-21 0:23 ` David Miller
2012-02-21 15:14 ` John W. Linville
2012-02-21 19:44 ` David Miller
2012-02-21 20:38 ` Andrei Emeltchenko
2012-02-21 20:40 ` David Miller
2012-02-21 20:59 ` [PATCH] checkpatch: Add some --strict coding style checks Joe Perches
2012-02-21 21:09 ` Andrew Morton
2012-02-21 21:11 ` Joe Perches
2012-02-21 22:09 ` Allan, Bruce W
2012-02-21 23:16 ` Joe Perches
2012-02-22 1:36 ` Joe Perches
2012-02-22 1:56 ` Allan, Bruce W
2012-02-22 1:58 ` Joe Perches
2012-02-22 2:17 ` Allan, Bruce W
2012-02-23 3:43 ` Joe Perches
2012-02-24 18:22 ` Allan, Bruce W
2012-02-24 18:37 ` [PATCH v2] " Joe Perches
2012-02-29 14:38 ` Kalle Valo [this message]
2012-02-22 9:35 ` [PATCH] " David Laight
2012-02-22 9:46 ` Johannes Berg
2012-02-22 10:07 ` pull request: wireless 2012-02-20 Zefir Kurtisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4E384D.2090802@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=akpm@linux-foundation.org \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=apw@shadowen.org \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome