From: "Jan Beulich" <JBeulich@suse.com>
To: "Joe Perches" <joe@perches.com>
Cc: <akpm@linux-foundation.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vsprintf: make %pV handling compatible with kasprintf()
Date: Tue, 06 Mar 2012 07:50:21 +0000 [thread overview]
Message-ID: <4F55CFCD02000078000768ED@nat28.tlf.novell.com> (raw)
In-Reply-To: <1330966942.3140.8.camel@joe2Laptop>
>>> On 05.03.12 at 18:02, Joe Perches <joe@perches.com> wrote:
> On Mon, 2012-03-05 at 16:49 +0000, Jan Beulich wrote:
>> kasprintf() (and potentially other functions that I didn't run across
>> so far) want to evaluate argument lists twice. Caring to do so for the
>> primary list is obviously their job, but they can't reasonably be
>> expected to check the format string for instances of %pV, which however
>> need special handling too: On architectures like x86-64 (as opposed to
>> e.g. ix86), using the same argument list twice doesn't produce the
>> expected results, as an internally managed cursor gets updated during
>> the first run.
>>
>> Fix the problem by always acting on a copy of the original list when
>> handling %pV.
>
> Wouldn't stable need this too?
Possibly, but I'm not certain - this is more of a latent bug that I ran
into with some not yet submitted Xen code. And I'm not sure
whether latent bugs qualify for stable...
Jan
prev parent reply other threads:[~2012-03-06 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 16:49 Jan Beulich
2012-03-05 17:02 ` Joe Perches
2012-03-06 7:50 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F55CFCD02000078000768ED@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®