From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758603Ab2CTOip (ORCPT ); Tue, 20 Mar 2012 10:38:45 -0400 Received: from [89.21.227.130] ([89.21.227.130]:42990 "EHLO mail.epsilon.itdev.co.uk" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754012Ab2CTOin (ORCPT ); Tue, 20 Mar 2012 10:38:43 -0400 X-Greylist: delayed 336 seconds by postgrey-1.27 at vger.kernel.org; Tue, 20 Mar 2012 10:38:43 EDT Message-ID: <4F68966F.9070303@itdev.co.uk> Date: Tue, 20 Mar 2012 07:38:39 -0700 From: Nick Dyer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Daniel Kurtz CC: Dmitry Torokhov , Joonyoung Shim , Iiro Valkonen , Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benson Leung , Yufeng Shen , "Bowens, Alan" , "Tiwari, Atul" Subject: Re: [PATCH 02/20] Input: atmel_mxt_ts - only allow root to update firmware References: <1331640263-18935-1-git-send-email-djkurtz@chromium.org> <1331640263-18935-3-git-send-email-djkurtz@chromium.org> In-Reply-To: <1331640263-18935-3-git-send-email-djkurtz@chromium.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Kurtz wrote: > Restrict permissions on the update_fw sysfs entry to read only for root > only. > > Also, update object permission to use a macro S_IRUGO macro instead of > hard coded 0444. > > Signed-off-by: Daniel Kurtz Acked-by: Nick Dyer