From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030261Ab2CTPBl (ORCPT ); Tue, 20 Mar 2012 11:01:41 -0400 Received: from [89.21.227.130] ([89.21.227.130]:34755 "EHLO mail.epsilon.itdev.co.uk" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1758036Ab2CTPBk (ORCPT ); Tue, 20 Mar 2012 11:01:40 -0400 Message-ID: <4F689BD0.7090002@itdev.co.uk> Date: Tue, 20 Mar 2012 08:01:36 -0700 From: Nick Dyer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Daniel Kurtz CC: Dmitry Torokhov , Joonyoung Shim , Iiro Valkonen , Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benson Leung , Yufeng Shen , "Tiwari, Atul" , "Bowens, Alan" Subject: Re: [PATCH 07/20] Input: atmel_mxt_ts - add backupnv sysfs entry References: <1331640263-18935-1-git-send-email-djkurtz@chromium.org> <1331640263-18935-8-git-send-email-djkurtz@chromium.org> In-Reply-To: <1331640263-18935-8-git-send-email-djkurtz@chromium.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Kurtz wrote: > Writing to the object sysfs entry permits individual object table entries > to be modified in the device RAM at run time. To permanently save > the settings, they must be written to Non-Volatile memory (NVM). > This patch adds a write-only sysfs entry to allow userspace to save > current settings to NVM, but restricts access to root. > > Signed-off-by: Daniel Kurtz The process to update the stored chip configuration should be: 1) Change config setting 2) Backup (with delay) 3) Reset (with delay) 4) Get driver to re-read resolution etc So I am worried that this is a half solution, and will lead to confusion. -- Nick Dyer Software Engineer, ITDev Ltd Hardware and Software Development Consultancy Website: http://www.itdev.co.uk