From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760580Ab2CTPam (ORCPT ); Tue, 20 Mar 2012 11:30:42 -0400 Received: from [89.21.227.130] ([89.21.227.130]:42147 "EHLO mail.epsilon.itdev.co.uk" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755008Ab2CTPal (ORCPT ); Tue, 20 Mar 2012 11:30:41 -0400 Message-ID: <4F68A29A.7060700@itdev.co.uk> Date: Tue, 20 Mar 2012 08:30:34 -0700 From: Nick Dyer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 Newsgroups: gmane.linux.kernel,gmane.linux.kernel.input To: Daniel Kurtz CC: Dmitry Torokhov , Joonyoung Shim , Iiro Valkonen , Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benson Leung , Yufeng Shen Subject: Re: [PATCH 17/20] Input: atmel_mxt_ts - use cached T9 reportid range in isr References: <1331640263-18935-1-git-send-email-djkurtz@chromium.org> <1331640263-18935-18-git-send-email-djkurtz@chromium.org> In-Reply-To: <1331640263-18935-18-git-send-email-djkurtz@chromium.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Kurtz wrote: > Streamline interrupt processing by caching the T9 reportid range when > first initializing the object table. > > Note: the cached T9 reportid's are initialized to 0, which is an invalid > reportid. Thus, the checks in the interrupt handler will always fail > for devices that do not support the T9 object. > > Signed-off-by: Daniel Kurtz You need to support the case where there are multiple T9 instances. -- Nick Dyer Software Engineer, ITDev Ltd Hardware and Software Development Consultancy Website: http://www.itdev.co.uk