From: Jiri Slaby <jslaby@suse.cz>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/tty/amiserial.c: add missing tty_unlock
Date: Thu, 19 Apr 2012 22:19:20 +0200 [thread overview]
Message-ID: <4F907348.9060201@suse.cz> (raw)
In-Reply-To: <1334851960-29409-1-git-send-email-Julia.Lawall@lip6.fr>
On 04/19/2012 06:12 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> tty_unlock is used on all other exits from the function.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Jiri Slaby <jslaby@suse.cz>
This is broken since 2008 BTW.
> ---
> drivers/tty/amiserial.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 24145c3..6cc4358 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -1073,8 +1073,10 @@ static int set_serial_info(struct tty_struct *tty, struct serial_state *state,
> (new_serial.close_delay != port->close_delay) ||
> (new_serial.xmit_fifo_size != state->xmit_fifo_size) ||
> ((new_serial.flags & ~ASYNC_USR_MASK) !=
> - (port->flags & ~ASYNC_USR_MASK)))
> + (port->flags & ~ASYNC_USR_MASK))) {
> + tty_unlock();
> return -EPERM;
> + }
> port->flags = ((port->flags & ~ASYNC_USR_MASK) |
> (new_serial.flags & ASYNC_USR_MASK));
> state->custom_divisor = new_serial.custom_divisor;
--
js
suse labs
prev parent reply other threads:[~2012-04-19 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 16:12 Julia Lawall
2012-04-19 20:19 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F907348.9060201@suse.cz \
--to=jslaby@suse.cz \
--cc=Julia.Lawall@lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome