From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756802Ab2D3Vae (ORCPT ); Mon, 30 Apr 2012 17:30:34 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:50745 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755439Ab2D3Vac (ORCPT ); Mon, 30 Apr 2012 17:30:32 -0400 X-Authenticated: #23875046 X-Provags-ID: V01U2FsdGVkX19Wv101TfdW50TZdjd5CM+lnKLZKKBBjy/w0VlaGs NwBGgJZD2/36JS Message-ID: <4F9F0473.9090408@fisher-privat.net> Date: Mon, 30 Apr 2012 23:30:27 +0200 From: Oleksij Rempel User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411 Thunderbird/11.0.1 MIME-Version: 1.0 To: Alan Stern CC: Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , ACPI Devel Mailing List , Linux PM list , linux-pci@vger.kernel.org, LKML , Andrey Rahmatullin , Steven Rostedt Subject: Re: [PATCH] ACPI / PCI: Make _SxD/_SxW check follow ACPI 4.0a spec References: In-Reply-To: X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.04.2012 19:53, Alan Stern wrote: > On Mon, 30 Apr 2012, Bjorn Helgaas wrote: > >> On Sun, Apr 29, 2012 at 2:44 PM, Rafael J. Wysocki wrote: >>> From: Oleksij Rempel >>> >>> This patch makes _SxD/_SxW check follow the ACPI 4.0a specification >>> more closely and fixes suspend bug found on ASUS Zenbook UX31E. >>> >>> Some OEM use _SxD fileds do blacklist brocken Dx states. >>> If _SxD/_SxW return values are check before suspend as appropriate, >>> some nasty suspend/resume issues may be avoided. >>> >>> References: https://bugzilla.kernel.org/show_bug.cgi?id=42728 >>> Signed-off-by: Oleksij Rempel >>> Signed-off-by: Rafael J. Wysocki >>> --- >>> >>> Bjorn, Len, >>> >>> This is -stable material and therefore v3.4 as well, IMO. �Please let me >>> know if one of you can take it or whether you want me to handle it all the >>> way to Linus. >> >> I'm OK with this from a PCI perspective. Most of the change is in >> ACPI, so I propose that either you or Len take care of it. >> >> The second paragraph of the changelog has several typos >> (fileds/fields, do/to, brocken/broken, etc). > > It also turns out that the normal wakeup mechanism doesn't work for the > devices in question. Can this be detected by ACPI? We don't want to > tell userspace that wakeup works when in fact it doesn't. hm... how about using pci config and acpi together. PCI config provides map of Dx states and wakeup support of them. If pci says wakeup works only on D0 and D3 and acpi say - we can use only D2 in S3, then there is no wakeup. -- Regards, Oleksij