From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753787Ab2IMNa3 (ORCPT ); Thu, 13 Sep 2012 09:30:29 -0400 Received: from mx2.netapp.com ([216.240.18.37]:44085 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752752Ab2IMNa1 (ORCPT ); Thu, 13 Sep 2012 09:30:27 -0400 X-IronPort-AV: E=Sophos;i="4.80,417,1344236400"; d="scan'208";a="689194735" From: "Myklebust, Trond" To: Stanislav Kinsbursky CC: Jeff Layton , "bfields@fieldses.org" , "linux-nfs@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@openvz.org" Subject: Re: [PATCH v2] SUNRPC: check current nsproxy before set of node name on client creation Thread-Topic: [PATCH v2] SUNRPC: check current nsproxy before set of node name on client creation Thread-Index: AQHNeUylwnVjh2tbW02Id+IcJKD75ZeAFAKAgAB9EYCAAI9kAIACwv6AgABw0oCAAALMAIAAAUkAgAR8GQCAABYngA== Date: Thu, 13 Sep 2012 13:30:25 +0000 Message-ID: <4FA345DA4F4AE44899BD2B03EEEC2FA908FA249D@SACEXCMBX04-PRD.hq.netapp.com> References: <20120813113731.9629.31906.stgit@localhost.localdomain> <20120813081054.0ee39037@corrin.poochiereds.net> <4FA345DA4F4AE44899BD2B03EEEC2FA908F90888@SACEXCMBX04-PRD.hq.netapp.com> <504ADED9.2020607@parallels.com> <4FA345DA4F4AE44899BD2B03EEEC2FA908F914D4@SACEXCMBX04-PRD.hq.netapp.com> <504DA833.60301@parallels.com> <4FA345DA4F4AE44899BD2B03EEEC2FA908F9547B@SACEXCMBX04-PRD.hq.netapp.com> <504E0930.5050408@parallels.com> <4FA345DA4F4AE44899BD2B03EEEC2FA908F96556@SACEXCMBX04-PRD.hq.netapp.com> <5051CD5C.1000902@parallels.com> In-Reply-To: <5051CD5C.1000902@parallels.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.104.60.116] Content-Type: text/plain; charset="utf-8" Content-ID: <966B701284247241A2209E1B0BF6C5F1@tahoe.netapp.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id q8DDUbnJ004983 On Thu, 2012-09-13 at 16:11 +0400, Stanislav Kinsbursky wrote: > 10.09.2012 19:41, Myklebust, Trond пишет: > > On Mon, 2012-09-10 at 19:37 +0400, Stanislav Kinsbursky wrote: > >> Hi, Trond. > >> So, if I understand you right, we can create rpc client (or increase usage > >> counter) on NSMPROC_MON call and destroy (or decrease usage counter) on > >> NSMPROC_UNMON call. > >> Will this solution works? > > > > The rpc client(s) will need to be per-net-namespace, which complicates > > matters a little bit, but yes, creation at NSMPROC_MON, and destruction > > at NSMPROC_UNMON should work. > > > > Hi, Trond. > With reference-counted NSM client I got this: > > BUG: unable to handle kernel NULL pointer dereference at 0000000000000008 > IP: [] encode_mon_id+0x2e/0x64 [lockd] > PGD 0 > Oops: 0000 [#1] SMP DEBUG_PAGEALLOC > Modules linked in: nfsv3 nfs_acl nfs lockd veth sunrpc bridge stp llc i2c_piix4 > i2c_core virtio_blk virtio_net floppy virtio_pci virtio_ring virtio > CPU 1 > Pid: 1174, comm: bash Not tainted 3.5.0-kitchensink+ #44 Bochs Bochs > RIP: 0010:[] [] encode_mon_id+0x2e/0x64 [lockd] > RSP: 0018:ffff88001d0f1a08 EFLAGS: 00010246 > RAX: 0000000000000000 RBX: ffff88001d0f1c38 RCX: 0000000000000000 > RDX: ffff88001c85803f RSI: ffff88001d23b204 RDI: ffff88001d0f1a48 > RBP: ffff88001d0f1a18 R08: ffff88001c858040 R09: 0000000000000003 > R10: ffff88001a5aba10 R11: ffff88001d0f1ac8 R12: ffff88001d0f1a48 > R13: ffff88001a8a3138 R14: ffffffffa008d580 R15: ffffffffa00c0db5 > FS: 00007f0d60eea700(0000) GS:ffff88001f700000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b > CR2: 0000000000000008 CR3: 000000001db3d000 CR4: 00000000000006e0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 > Process bash (pid: 1174, threadinfo ffff88001d0f0000, task ffff88001d1f4160) > Stack: > ffff88001d0f1a48 ffff88001c858030 ffff88001d0f1a28 ffffffffa00c0dc9 > ffff88001d0f1ab8 ffffffffa00731a0 ffff88001a5aba10 ffff88001d0f1c38 > ffff88001c858040 ffff88001a8a3140 ffff88001c858854 ffff88001a8a3140 > Call Trace: > [] nsm_xdr_enc_unmon+0x14/0x16 [lockd] > [] rpcauth_wrap_req+0xa1/0xb2 [sunrpc] > [] ? xprt_prepare_transmit+0x83/0x93 [sunrpc] > [] call_transmit+0x1e4/0x263 [sunrpc] > [] __rpc_execute+0xe7/0x313 [sunrpc] > [] ? call_transmit_status+0xb8/0xb8 [sunrpc] > [] ? wake_up_bit+0x25/0x2a > [] rpc_execute+0x9d/0xa5 [sunrpc] > [] rpc_run_task+0x7e/0x86 [sunrpc] > [] rpc_call_sync+0x44/0x65 [sunrpc] > [] nsm_mon_unmon+0x81/0xad [lockd] > [] nsm_unmonitor+0x82/0x13a [lockd] > [] nlm_destroy_host_locked+0x93/0xc9 [lockd] > [] nlmclnt_release_host+0xb3/0xc3 [lockd] > [] nlmclnt_done+0x1a/0x26 [lockd] > [] nfs_destroy_server+0x24/0x26 [nfs] > [] nfs_free_server+0xad/0x134 [nfs] > [] nfs_kill_super+0x22/0x26 [nfs] > [] deactivate_locked_super+0x26/0x57 > [] deactivate_super+0x45/0x4c > [] mntput_no_expire+0x110/0x119 > [] mntput+0x2a/0x2c > [] release_mounts+0x72/0x84 > [] put_mnt_ns+0x6f/0x7e > [] free_nsproxy+0x1f/0x87 > [] switch_task_namespaces+0x5c/0x65 > [] exit_task_namespaces+0x10/0x12 > [] do_exit+0x69b/0x84f > [] do_group_exit+0x83/0xae > [] sys_exit_group+0x17/0x1b > [] system_call_fastpath+0x16/0x1b > Code: e5 41 54 53 66 66 66 66 90 48 89 f3 49 89 fc 48 8b 76 18 e8 93 ff ff ff 4c > 89 e7 65 48 8b 04 25 c0 b9 00 00 48 8b 80 00 05 00 00 <48> 8b 70 08 48 83 c6 45 > e8 73 ff ff ff 4c 89 e7 be 0c 00 00 00 > RIP [] encode_mon_id+0x2e/0x64 [lockd] > > > There are more places, where NFS and Lockd code dereference utsname(). > In XDR layer, for instance. > > So, probably, we have to tie NFS to utsns as well as to netns. > Add one more ns to xprt? What do you think? > We've already saved the utsname in the rpc_client as clnt->cl_nodename. All XDR users can be trivially converted to use that. Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I