From: Martin <marogge@onlinehome.de>
To: Hillf Danton <dhillf@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: BFS 420: cleanup in tick handling
Date: Sun, 20 May 2012 11:01:26 +0200 [thread overview]
Message-ID: <4FB8B2E6.5010601@onlinehome.de> (raw)
In-Reply-To: <j2MgV-2Qe-9@gated-at.bofh.it>
On 05/19/2012 09:30 AM, Hillf Danton wrote:
> The cpu on stack is not needed, so remove it.
>
> --- a/kernel/sched/bfs.c Mon May 14 20:50:38 2012
> +++ b/kernel/sched/bfs.c Sat May 19 15:18:24 2012
> @@ -2822,8 +2822,7 @@ void wake_up_idle_cpu(int cpu);
> */
> void scheduler_tick(void)
> {
> - int cpu __maybe_unused = smp_processor_id();
> - struct rq *rq = cpu_rq(cpu);
> + struct rq *rq = this_rq();
>
> sched_clock_tick();
> /* grq lock not grabbed, so only update rq clock */
> --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
Hillf, I noticed you posting a few patches to BFS recently. Just wanted
to make you aware that there is a certain erm communication issue
between the kernel maintainers and the author of BFS. Since he is busy
in real life you should contact him directly or cc him. See tail -1
Documentation/scheduler/sched-BFS.txt for email.
next parent reply other threads:[~2012-05-20 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <j2MgV-2Qe-9@gated-at.bofh.it>
2012-05-20 9:01 ` Martin [this message]
2012-05-22 12:42 ` Hillf Danton
[not found] ` <CANQmPXh+0LECyLJ-MrDBZf2ZwLv5BJk0+DCFgPzqSChrFV=2WA@mail.gmail.com>
2012-05-22 13:50 ` Hillf Danton
[not found] ` <CANQmPXhYMbDG7Wiaiwbr3J+Fft3FnaS=RM2t=FSRN-hYDSbMzw@mail.gmail.com>
2012-05-22 14:04 ` Hillf Danton
[not found] ` <CANQmPXgqjSuo0jy-O04-qp64b4J-Lk64sv0wzmdG1yUtc9v-Sw@mail.gmail.com>
2012-05-22 14:09 ` Hillf Danton
2012-05-23 13:28 ` Hillf Danton
2012-05-19 7:23 Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB8B2E6.5010601@onlinehome.de \
--to=marogge@onlinehome.de \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®