From: Chanwoo Choi <cw00.choi@samsung.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: broonie@opensource.wolfsonmicro.com, thomas.abraham@linaro.org,
grant.likely@secretlab.ca, sameo@linux.intel.com,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mfd: add irq domain support for max8997 interrupts
Date: Mon, 21 May 2012 08:28:34 +0900 [thread overview]
Message-ID: <4FB97E22.7090604@samsung.com> (raw)
In-Reply-To: <20120518235916.GA14015@kroah.com>
Hi Greg,
On 05/19/2012 08:59 AM, Greg KH wrote:
> On Wed, May 16, 2012 at 04:41:44PM +0900, Chanwoo Choi wrote:
>> From: Thomas Abraham <thomas.abraham@linaro.org>
>>
>> Add irq domain support for max8997 interrupts. The reverse mapping method
>> used is linear mapping since the sub-drivers of max8997 such as regulator
>> and charger drivers can use the max8997 irq_domain to get the linux irq
>> number for max8997 interrupts. All uses of irq_base in platform data and
>> max8997 driver private data are removed.
>>
>> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
>> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
>> Acked-by: Grant Likely <grant.likely@secretlab.ca>
>> Acked-by: Samuel Ortiz <sameo@linux.intel.com>
>> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>> [Fix two bug which set max8997->irq_domain and correct wrong parameter]
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> Same problem as before, I apply this and it breaks the build with the
> following errors:
>
> drivers/extcon/extcon-max8997.c: In function ‘max8997_muic_irq_work’:
> drivers/extcon/extcon-max8997.c:350:36: error: ‘struct max8997_dev’ has no member named ‘irq_base’
> drivers/extcon/extcon-max8997.c: In function ‘max8997_muic_probe’:
> drivers/extcon/extcon-max8997.c:452:35: error: ‘struct max8997_platform_data’ has no member named ‘irq_base’
> drivers/extcon/extcon-max8997.c: In function ‘max8997_muic_remove’:
> drivers/extcon/extcon-max8997.c:514:19: error: ‘struct max8997_dev’ has no member named ‘irq_base’
>
> Please fix.
I posted patchset including below two patch. The second patch fix that
extcon-max8997 driver use irq_domain instead of irq_base field in
'struct max8997_dev'.
Please apply second patch when test this patchset.
If you want to consolidate this patchset, I will resend it.
[PATCH v3 1/2] mfd: add irq domain support for max8997 interrupts
[PATCH v3 2/2] Extcon: MAX8997: Add support irq domain for MAX8997 muic
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2012-05-20 23:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 7:41 Chanwoo Choi
2012-05-18 23:59 ` Greg KH
2012-05-20 23:28 ` Chanwoo Choi [this message]
2012-05-21 2:29 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2012-02-23 12:38 [PATCH v3 0/2] regulator: add irq domain and device tree support for MAX8997 Thomas Abraham
2012-02-23 12:38 ` [PATCH v3 1/2] mfd: add irq domain support for max8997 interrupts Thomas Abraham
2012-03-13 3:28 ` Grant Likely
2012-03-13 6:05 ` Thomas Abraham
2012-03-13 8:15 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB97E22.7090604@samsung.com \
--to=cw00.choi@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome