From: Amos Kong <akong@redhat.com>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Li Zefan <lizefan@huawei.com>,
Serge Hallyn <serge.hallyn@canonical.com>,
containers@lists.linux-foundation.org, mtosatti@redhat.com,
linux-kernel@vger.kernel.org, tj@kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH] cgroup: fix device deny of DEV_ALL
Date: Tue, 22 May 2012 10:23:11 +0800 [thread overview]
Message-ID: <4FBAF88F.1040103@redhat.com> (raw)
In-Reply-To: <20120522020857.GA10499@mail.hallyn.com>
On 22/05/12 10:08, Serge E. Hallyn wrote:
> At line 135, there is
>
> if (walk->type == DEV_ALL)
> goto remove;
>
> I wonder if that was meant to be 'if (wh->type == DEV_ALL)'. That
> seems to fit better with what I would have meant to have happen.
> But it's already handled by line 342. So I think deleting lines
> 135-136 might be best. What do you think?
Hi Serge,
If we expect nothing changed ('a *:* rwm' doesn't change),
delete 135-136 will be ok.
But I have explained my patch in another email, I also think
it's unnecessary to remove 'a *:* rwm' before executing:
@ echo 'b 253:3 rw'> devices.deny
--
Amos.
next prev parent reply other threads:[~2012-05-22 2:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-15 0:39 cgroup: denying device doesn't work with 'rw' mode string Amos Kong
2012-05-18 3:37 ` Amos Kong
2012-05-18 3:52 ` Li Zefan
2012-05-18 4:31 ` Amos Kong
2012-05-18 7:46 ` Amos Kong
2012-05-18 8:19 ` [PATCH] cgroup: fix device deny of DEV_ALL Amos Kong
2012-05-21 14:03 ` Serge Hallyn
2012-05-22 0:34 ` Li Zefan
2012-05-22 1:54 ` Serge E. Hallyn
2012-05-22 2:08 ` Serge E. Hallyn
2012-05-22 2:23 ` Amos Kong [this message]
2012-05-22 2:14 ` Amos Kong
2012-05-22 12:48 ` Serge Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBAF88F.1040103@redhat.com \
--to=akong@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mtosatti@redhat.com \
--cc=serge.hallyn@canonical.com \
--cc=serge@hallyn.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome