From: Ian Abbott <abbotti@mev.co.uk>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Ian Abbott <ian.abbott@mev.co.uk>,
"fmhess@users.sourceforge.net" <fmhess@users.sourceforge.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: comedi: remove private header comedi_pci.h
Date: Tue, 22 May 2012 11:06:24 +0100 [thread overview]
Message-ID: <4FBB6520.10305@mev.co.uk> (raw)
In-Reply-To: <201205211712.12753.hartleys@visionengravers.com>
On 2012-05-22 01:12, H Hartley Sweeten wrote:
> Remove the private header, comedi_pci.h, by moving the two
> helper functions into divers.c and providing the prototypes
> in comedidev.h.
>
> This allows the comedi_pci_enable/disable helper functions
> to be shared instead of having an inline version in every
> comedi pci driver.
I'm wondering if these functions should be EXPORT_SYMBOL() or
EXPORT_SYMBOL_GPL() since they were originally inline functions.
Opinions?
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2012-05-22 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 0:12 H Hartley Sweeten
2012-05-22 10:06 ` Ian Abbott [this message]
2012-06-05 3:23 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBB6520.10305@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hartleys@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome